Moved ExternalExtensionLoaders/Providers into extensions namespace

chrome/browser/extensions/external_provider_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "chrome/browser/extensions/external_extension_provider_impl.h"
+#include "chrome/browser/extensions/external_provider_impl.h"
 
 #include "base/command_line.h"
 #include "base/file_path.h"
 #include "base/logging.h"
 #include "base/memory/linked_ptr.h"
 #include "base/metrics/field_trial.h"
 #include "base/path_service.h"
 #include "base/string_util.h"
 #include "base/values.h"
 #include "base/version.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/extensions/extension_service.h"
-#include "chrome/browser/extensions/external_extension_provider_interface.h"
-#include "chrome/browser/extensions/external_policy_extension_loader.h"
-#include "chrome/browser/extensions/external_pref_extension_loader.h"
+#include "chrome/browser/extensions/external_provider_interface.h"
+#include "chrome/browser/extensions/external_policy_loader.h"
+#include "chrome/browser/extensions/external_pref_loader.h"

[Joao da Silva, 2012/07/13 13:33:42]

Nit: order

[Devlin, 2012/07/13 16:31:17]

Done.

 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "content/public/browser/browser_thread.h"
 #include "ui/base/l10n/l10n_util.h"
 
 #if defined(OS_CHROMEOS)
 #include "chrome/browser/chromeos/login/user_manager.h"
 #include "chrome/browser/policy/app_pack_updater.h"
 #include "chrome/browser/policy/browser_policy_connector.h"
 #endif
 
 #if !defined(OS_CHROMEOS)
 #include "chrome/browser/extensions/default_apps.h"
 #endif
 
 #if defined(OS_WIN)
-#include "chrome/browser/extensions/external_registry_extension_loader_win.h"
+#include "chrome/browser/extensions/external_registry_loader_win.h"
 #endif
 
 using content::BrowserThread;
-using extensions::Extension;
+
+namespace extensions {
 
 // Constants for keeping track of extension preferences in a dictionary.
-const char ExternalExtensionProviderImpl::kExternalCrx[] = "external_crx";
-const char ExternalExtensionProviderImpl::kExternalVersion[] =
+const char ExternalProviderImpl::kExternalCrx[] = "external_crx";
+const char ExternalProviderImpl::kExternalVersion[] =
     "external_version";
-const char ExternalExtensionProviderImpl::kExternalUpdateUrl[] =
+const char ExternalProviderImpl::kExternalUpdateUrl[] =
     "external_update_url";
-const char ExternalExtensionProviderImpl::kSupportedLocales[] =
+const char ExternalProviderImpl::kSupportedLocales[] =
     "supported_locales";
-const char ExternalExtensionProviderImpl::kIsBookmarkApp[] =
+const char ExternalProviderImpl::kIsBookmarkApp[] =
     "is_bookmark_app";
 
-ExternalExtensionProviderImpl::ExternalExtensionProviderImpl(
+ExternalProviderImpl::ExternalProviderImpl(
     VisitorInterface* service,
-    ExternalExtensionLoader* loader,
+    ExternalLoader* loader,
     Extension::Location crx_location,
     Extension::Location download_location,
     int creation_flags)
   : crx_location_(crx_location),
     download_location_(download_location),
     service_(service),
     prefs_(NULL),
     ready_(false),
     loader_(loader),
     creation_flags_(creation_flags),
     auto_acknowledge_(false) {
   loader_->Init(this);
 }
 
-ExternalExtensionProviderImpl::~ExternalExtensionProviderImpl() {
+ExternalProviderImpl::~ExternalProviderImpl() {
   CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   loader_->OwnerShutdown();
 }
 
-void ExternalExtensionProviderImpl::VisitRegisteredExtension() {
+void ExternalProviderImpl::VisitRegisteredExtension() {
   // The loader will call back to SetPrefs.
   loader_->StartLoading();
 }
 
-void ExternalExtensionProviderImpl::SetPrefs(DictionaryValue* prefs) {
+void ExternalProviderImpl::SetPrefs(DictionaryValue* prefs) {
   CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   // Check if the service is still alive. It is possible that it went
   // away while |loader_| was working on the FILE thread.
   if (!service_) return;
 
   prefs_.reset(prefs);
   ready_ = true; // Queries for extensions are allowed from this point.
 
   // Set of unsupported extensions that need to be deleted from prefs_.
@@ skipping 157 matching lines @@
   for (std::set<std::string>::iterator it = unsupported_extensions.begin();
        it != unsupported_extensions.end(); ++it) {
     // Remove extension for the list of know external extensions. The extension
     // will be uninstalled later because provider doesn't provide it anymore.
     prefs_->Remove(*it, NULL);
   }
 
   service_->OnExternalProviderReady(this);
 }
 
-void ExternalExtensionProviderImpl::ServiceShutdown() {
+void ExternalProviderImpl::ServiceShutdown() {
   service_ = NULL;
 }
 
-bool ExternalExtensionProviderImpl::IsReady() const {
+bool ExternalProviderImpl::IsReady() const {
   return ready_;
 }
 
-bool ExternalExtensionProviderImpl::HasExtension(
+bool ExternalProviderImpl::HasExtension(
     const std::string& id) const {
   CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   CHECK(prefs_.get());
   CHECK(ready_);
   return prefs_->HasKey(id);
 }
 
-bool ExternalExtensionProviderImpl::GetExtensionDetails(
+bool ExternalProviderImpl::GetExtensionDetails(
     const std::string& id, Extension::Location* location,
     scoped_ptr<Version>* version) const {
   CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   CHECK(prefs_.get());
   CHECK(ready_);
   DictionaryValue* extension = NULL;
   if (!prefs_->GetDictionary(id, &extension))
     return false;
 
   Extension::Location loc = Extension::INVALID;
@@ skipping 15 matching lines @@
     return false;
   }
 
   if (location)
     *location = loc;
 
   return true;
 }
 
 // static
-void ExternalExtensionProviderImpl::CreateExternalProviders(
+void ExternalProviderImpl::CreateExternalProviders(
     VisitorInterface* service,
     Profile* profile,
     ProviderCollection* provider_list) {
 
   // On Mac OS, items in /Library/... should be written by the superuser.
   // Check that all components of the path are writable by root only.
-  ExternalPrefExtensionLoader::Options check_admin_permissions_on_mac;
+  ExternalPrefLoader::Options check_admin_permissions_on_mac;
 #if defined(OS_MACOSX)
   check_admin_permissions_on_mac =
-    ExternalPrefExtensionLoader::ENSURE_PATH_CONTROLLED_BY_ADMIN;
+    ExternalPrefLoader::ENSURE_PATH_CONTROLLED_BY_ADMIN;
 #else
-  check_admin_permissions_on_mac = ExternalPrefExtensionLoader::NONE;
+  check_admin_permissions_on_mac = ExternalPrefLoader::NONE;
 #endif
 
   bool is_chromeos_demo_session = false;
   int bundled_extension_creation_flags = Extension::NO_FLAGS;
 #if defined(OS_CHROMEOS)
   chromeos::UserManager* user_manager = chromeos::UserManager::Get();
   is_chromeos_demo_session =
       user_manager && user_manager->IsLoggedInAsDemoUser() &&
       g_browser_process->browser_policy_connector()->GetDeviceMode() ==
           policy::DEVICE_MODE_KIOSK;
   bundled_extension_creation_flags = Extension::FROM_WEBSTORE;
 #endif
 
   if (!is_chromeos_demo_session) {
     provider_list->push_back(
-        linked_ptr<ExternalExtensionProviderInterface>(
-            new ExternalExtensionProviderImpl(
+        linked_ptr<ExternalProviderInterface>(
+            new ExternalProviderImpl(
                 service,
-                new ExternalPrefExtensionLoader(
-                    chrome::DIR_EXTERNAL_EXTENSIONS,
-                    check_admin_permissions_on_mac),
+                new ExternalPrefLoader(chrome::DIR_EXTERNAL_EXTENSIONS,
+                                       check_admin_permissions_on_mac),
                 Extension::EXTERNAL_PREF,
                 Extension::EXTERNAL_PREF_DOWNLOAD,
                 bundled_extension_creation_flags)));
   }
 
 #if defined(OS_CHROMEOS) || defined (OS_MACOSX)
   // Define a per-user source of external extensions.
   // On Chrome OS, this serves as a source for OEM customization.
   provider_list->push_back(
-      linked_ptr<ExternalExtensionProviderInterface>(
-          new ExternalExtensionProviderImpl(
+      linked_ptr<ExternalProviderInterface>(
+          new ExternalProviderImpl(
               service,
-              new ExternalPrefExtensionLoader(
-                  chrome::DIR_USER_EXTERNAL_EXTENSIONS,
-                  ExternalPrefExtensionLoader::NONE),
+              new ExternalPrefLoader(chrome::DIR_USER_EXTERNAL_EXTENSIONS,
+                                     ExternalPrefLoader::NONE),
               Extension::EXTERNAL_PREF,
               Extension::EXTERNAL_PREF_DOWNLOAD,
               Extension::NO_FLAGS)));
 #endif
 #if defined(OS_WIN)
   provider_list->push_back(
-      linked_ptr<ExternalExtensionProviderInterface>(
-          new ExternalExtensionProviderImpl(
+      linked_ptr<ExternalProviderInterface>(
+          new ExternalProviderImpl(
               service,
-              new ExternalRegistryExtensionLoader,
+              new ExternalRegistryLoader,
               Extension::EXTERNAL_REGISTRY,
               Extension::INVALID,
               Extension::NO_FLAGS)));
 #endif
 
 #if defined(OS_LINUX) && !defined(OS_CHROMEOS)
   provider_list->push_back(
-      linked_ptr<ExternalExtensionProviderInterface>(
-          new ExternalExtensionProviderImpl(
+      linked_ptr<ExternalProviderInterface>(
+          new ExternalProviderImpl(
               service,
-              new ExternalPrefExtensionLoader(
-                  chrome::DIR_STANDALONE_EXTERNAL_EXTENSIONS,
-                  ExternalPrefExtensionLoader::NONE),
+              new ExternalPrefLoader(chrome::DIR_STANDALONE_EXTERNAL_EXTENSIONS,
+                                     ExternalPrefLoader::NONE),
               Extension::EXTERNAL_PREF,
               Extension::EXTERNAL_PREF_DOWNLOAD,
               Extension::NO_FLAGS)));
 #endif
 
   provider_list->push_back(
-      linked_ptr<ExternalExtensionProviderInterface>(
-          new ExternalExtensionProviderImpl(
+      linked_ptr<ExternalProviderInterface>(
+          new ExternalProviderImpl(
               service,
-              new ExternalPolicyExtensionLoader(profile),
+              new ExternalPolicyLoader(profile),
               Extension::INVALID,
               Extension::EXTERNAL_POLICY_DOWNLOAD,
               Extension::NO_FLAGS)));
 
 #if !defined(OS_CHROMEOS)
   provider_list->push_back(
-      linked_ptr<ExternalExtensionProviderInterface>(
+      linked_ptr<ExternalProviderInterface>(
           new default_apps::Provider(
               profile,
               service,
-              new ExternalPrefExtensionLoader(
-                  chrome::DIR_DEFAULT_APPS,
-                  ExternalPrefExtensionLoader::NONE),
+              new ExternalPrefLoader(chrome::DIR_DEFAULT_APPS,
+                                     ExternalPrefLoader::NONE),
               Extension::EXTERNAL_PREF,
               Extension::INVALID,
               Extension::FROM_WEBSTORE)));
 #endif
 
 #if defined(OS_CHROMEOS)
   policy::BrowserPolicyConnector* connector =
       g_browser_process->browser_policy_connector();
   if (is_chromeos_demo_session && connector->GetAppPackUpdater()) {
     provider_list->push_back(
-        linked_ptr<ExternalExtensionProviderInterface>(
-          new ExternalExtensionProviderImpl(
+        linked_ptr<ExternalProviderInterface>(
+          new ExternalProviderImpl(
               service,
-              connector->GetAppPackUpdater()->CreateExternalExtensionLoader(),
+              connector->GetAppPackUpdater()->CreateExternalLoader(),
               Extension::EXTERNAL_PREF,
               Extension::INVALID,
               Extension::NO_FLAGS)));
   }
 #endif
 }
+
+}  // namespace extensions