chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc - Issue 10692164: Remove browser::FindTabbedBrowser call in bookmark_utils.cc. All callers, with the exception of met…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc

Issue 10692164: Remove browser::FindTabbedBrowser call in bookmark_utils.cc. All callers, with the exception of met… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm ('k') | chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc

===================================================================

--- chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc (revision 146039)

+++ chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc (working copy)

@@ -1150,10 +1150,10 @@

DCHECK(node->is_url());

DCHECK(page_navigator_);

- Profile* profile = browser_->profile();

- RecordAppLaunch(profile, node->url());

- bookmark_utils::OpenAll(window_->GetNativeWindow(), profile, page_navigator_,

- node, event_utils::DispositionForCurrentButtonPressEvent());

+ RecordAppLaunch(browser_->profile(), node->url());

+ bookmark_utils::OpenAll(

+ window_->GetNativeWindow(), page_navigator_, node,

+ event_utils::DispositionForCurrentButtonPressEvent());

content::RecordAction(UserMetricsAction("ClickedBookmarkBarURLButton"));

}

@@ -1237,8 +1237,8 @@

PopupForButton(sender);

} else if (event->button.button == 2) {

const BookmarkNode* node = GetNodeForToolButton(sender);

- bookmark_utils::OpenAll(window_->GetNativeWindow(), browser_->profile(),

- page_navigator_, node, NEW_BACKGROUND_TAB);

+ bookmark_utils::OpenAll(window_->GetNativeWindow(), page_navigator_, node,

+ NEW_BACKGROUND_TAB);

}