chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc - Issue 10692164: Remove browser::FindTabbedBrowser call in bookmark_utils.cc. All callers, with the exception of met…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

Issue 10692164: Remove browser::FindTabbedBrowser call in bookmark_utils.cc. All callers, with the exception of met… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.cc ('k') | chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

===================================================================

--- chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc (revision 146039)

+++ chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc (working copy)

@@ -1042,16 +1042,16 @@

WindowOpenDisposition disposition_from_event_flags =

chrome::DispositionFromEventFlags(sender->mouse_event_flags());

- Profile* profile = browser_->profile();

if (node->is_url()) {

- RecordAppLaunch(profile, node->url());

+ RecordAppLaunch(browser_->profile(), node->url());

OpenURLParams params(

node->url(), Referrer(), disposition_from_event_flags,

content::PAGE_TRANSITION_AUTO_BOOKMARK, false);

page_navigator_->OpenURL(params);

} else {

- bookmark_utils::OpenAll(GetWidget()->GetNativeWindow(), profile,

- page_navigator_, node, disposition_from_event_flags);

+ bookmark_utils::OpenAll(

+ GetWidget()->GetNativeWindow(), page_navigator_, node,

+ disposition_from_event_flags);

}

bookmark_utils::RecordBookmarkLaunch(IsDetached() ?