Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8781)

Unified Diff: chrome/common/extensions/matcher/url_matcher_unittest.cc

Issue 10692158: Refactor URLBlacklistManager to use URLMatcher. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: joao Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/matcher/url_matcher.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/matcher/url_matcher_unittest.cc
diff --git a/chrome/common/extensions/matcher/url_matcher_unittest.cc b/chrome/common/extensions/matcher/url_matcher_unittest.cc
index f2d513355b8e28158b34ff2d64936b705c90d3b5..add8530ff137e8a70b29c91302e9502aa71d2888 100644
--- a/chrome/common/extensions/matcher/url_matcher_unittest.cc
+++ b/chrome/common/extensions/matcher/url_matcher_unittest.cc
@@ -165,6 +165,48 @@ TEST(URLMatcherConditionFactoryTest, GURLCharacterSet) {
EXPECT_FALSE(IsStringASCII(url.ref()));
}
+TEST(URLMatcherConditionFactoryTest, Criteria) {
+ URLMatcherConditionFactory factory;
+ EXPECT_EQ(URLMatcherCondition::HOST_PREFIX,
+ factory.CreateHostPrefixCondition("foo").criterion());
+ EXPECT_EQ(URLMatcherCondition::HOST_SUFFIX,
+ factory.CreateHostSuffixCondition("foo").criterion());
+ EXPECT_EQ(URLMatcherCondition::HOST_CONTAINS,
+ factory.CreateHostContainsCondition("foo").criterion());
+ EXPECT_EQ(URLMatcherCondition::HOST_EQUALS,
+ factory.CreateHostEqualsCondition("foo").criterion());
+ EXPECT_EQ(URLMatcherCondition::PATH_PREFIX,
+ factory.CreatePathPrefixCondition("foo").criterion());
+ EXPECT_EQ(URLMatcherCondition::PATH_SUFFIX,
+ factory.CreatePathSuffixCondition("foo").criterion());
+ EXPECT_EQ(URLMatcherCondition::PATH_CONTAINS,
+ factory.CreatePathContainsCondition("foo").criterion());
+ EXPECT_EQ(URLMatcherCondition::PATH_EQUALS,
+ factory.CreatePathEqualsCondition("foo").criterion());
+ EXPECT_EQ(URLMatcherCondition::QUERY_PREFIX,
+ factory.CreateQueryPrefixCondition("foo").criterion());
+ EXPECT_EQ(URLMatcherCondition::QUERY_SUFFIX,
+ factory.CreateQuerySuffixCondition("foo").criterion());
+ EXPECT_EQ(URLMatcherCondition::QUERY_CONTAINS,
+ factory.CreateQueryContainsCondition("foo").criterion());
+ EXPECT_EQ(URLMatcherCondition::QUERY_EQUALS,
+ factory.CreateQueryEqualsCondition("foo").criterion());
+ EXPECT_EQ(URLMatcherCondition::HOST_SUFFIX_PATH_PREFIX,
+ factory.CreateHostSuffixPathPrefixCondition("foo",
+ "bar").criterion());
+ EXPECT_EQ(URLMatcherCondition::HOST_EQUALS_PATH_PREFIX,
+ factory.CreateHostEqualsPathPrefixCondition("foo",
+ "bar").criterion());
+ EXPECT_EQ(URLMatcherCondition::URL_PREFIX,
+ factory.CreateURLPrefixCondition("foo").criterion());
+ EXPECT_EQ(URLMatcherCondition::URL_SUFFIX,
+ factory.CreateURLSuffixCondition("foo").criterion());
+ EXPECT_EQ(URLMatcherCondition::URL_CONTAINS,
+ factory.CreateURLContainsCondition("foo").criterion());
+ EXPECT_EQ(URLMatcherCondition::URL_EQUALS,
+ factory.CreateURLEqualsCondition("foo").criterion());
+}
+
TEST(URLMatcherConditionFactoryTest, TestSingletonProperty) {
URLMatcherConditionFactory factory;
URLMatcherCondition c1 = factory.CreateHostEqualsCondition("www.google.com");
@@ -272,6 +314,15 @@ TEST(URLMatcherConditionFactoryTest, TestComponentSearches) {
"google.com", ""), url));
EXPECT_FALSE(Matches(factory.CreateHostSuffixPathPrefixCondition(
"www", ""), url));
+
+ EXPECT_TRUE(Matches(factory.CreateHostEqualsPathPrefixCondition(
+ "www.google.com", "/webhp"), url));
+ EXPECT_FALSE(Matches(factory.CreateHostEqualsPathPrefixCondition(
+ "", "/webhp"), url));
+ EXPECT_TRUE(Matches(factory.CreateHostEqualsPathPrefixCondition(
+ "www.google.com", ""), url));
+ EXPECT_FALSE(Matches(factory.CreateHostEqualsPathPrefixCondition(
+ "google.com", ""), url));
}
TEST(URLMatcherConditionFactoryTest, TestFullSearches) {
« no previous file with comments | « chrome/common/extensions/matcher/url_matcher.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698