Issue 10692153: Fix the errors for run_tests.py

Issue 10692153: Fix the errors for run_tests.py (Closed)

Created:
8 years, 5 months ago by yongsheng

Modified:
8 years, 5 months ago

Reviewers:
John Grabowski, bulach, Wei James(wistoch), gone

CC:
chromium-reviews

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

More Reviews

Description

Fix the errors for run_tests.py Module and methods changes: 1. run_tests_helper -> constants 2. FromOkAndFailed -> FromRun 3. Remove duplicated apk check BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146099

Patch Set 1 #

Patch Set 2 : Fix another issue #

Patch Set 3 : Remove duplicated code for apk check #

Patch Set 4 : Support to specific test suite #

Total comments: 3

Patch Set 5 : Refine it according to bulach's comments #

Total comments: 2

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -17 lines)			Patch
	M	build/android/run_tests.py	View	1 2 3 4	5 chunks	+12 lines, -17 lines	2 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

yongsheng

On 2012/07/11 07:15:09, yongsheng.zhu wrote: > I'm blocked by this. Please review it. thanks ok, ...

8 years, 5 months ago (2012-07-11 07:48:46 UTC) #2

yongsheng

On 2012/07/11 07:48:46, yongsheng.zhu wrote: > On 2012/07/11 07:15:09, yongsheng.zhu wrote: > > I'm blocked ...

8 years, 5 months ago (2012-07-11 07:54:56 UTC) #3

yongsheng

James, thanks very much to raise issues and help work out the patch.

8 years, 5 months ago (2012-07-11 08:16:18 UTC) #4

bulach

lgtm, thanks! just a few nits below: http://codereview.chromium.org/10692153/diff/6001/build/android/run_tests.py File build/android/run_tests.py (right): http://codereview.chromium.org/10692153/diff/6001/build/android/run_tests.py#newcode79 build/android/run_tests.py:79: def FullyQualifiedTestSuites(apk, ...

8 years, 5 months ago (2012-07-11 09:04:22 UTC) #5

yongsheng

On 2012/07/11 09:04:22, bulach wrote: > lgtm, thanks! thanks, bulach. done according to your comments. ...

8 years, 5 months ago (2012-07-11 09:14:09 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yongsheng.zhu@intel.com/10692153/5002

8 years, 5 months ago (2012-07-11 09:38:22 UTC) #8

gone

https://chromiumcodereview.appspot.com/10692153/diff/5002/build/android/run_tests.py File build/android/run_tests.py (right): https://chromiumcodereview.appspot.com/10692153/diff/5002/build/android/run_tests.py#newcode204 build/android/run_tests.py:204: 'out', 'Release')) Saw this line during our downstream merge. ...

8 years, 5 months ago (2012-07-11 21:55:17 UTC) #10

yongsheng

8 years, 5 months ago (2012-07-12 01:34:44 UTC) #11

https://chromiumcodereview.appspot.com/10692153/diff/5002/build/android/run_t...
File build/android/run_tests.py (right):

https://chromiumcodereview.appspot.com/10692153/diff/5002/build/android/run_t...
build/android/run_tests.py:204: 'out', 'Release'))
On 2012/07/11 21:55:17, dfalcantara wrote:
> Saw this line during our downstream merge.  Is it still necessary?
oh, I think you're right. should be removed. I'll do it. thanks for your info.

Expand Messages | Collapse Messages