Issue 10692146: Fix more incorrect usage of BrowserContext on the FILE thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10692146: Fix more incorrect usage of BrowserContext on the FILE thread. (Closed)

Created:
8 years, 5 months ago by jam

Modified:
8 years, 5 months ago

Reviewers:
awong

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix more incorrect usage of BrowserContext on the FILE thread. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146025

Patch Set 1 #

Patch Set 2 : fix another misuse #

Patch Set 3 : fix yet another misuse #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -22 lines)			Patch
M	chrome/browser/chromeos/extensions/file_browser_private_api.h	View		2 chunks	+8 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_browser_private_api.cc	View		10 chunks	+22 lines, -11 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_handler_util.cc	View	1 2	8 chunks	+13 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

awong

8 years, 5 months ago (2012-07-10 23:05:37 UTC) #2

LGTM

This really starts to make me want a "ThreadBoundPtr" smart pointer.

Expand Messages | Collapse Messages