Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 10692141: Fix the issue that Flash-related options are not showed on Chrome OS. (Closed)

Created:
8 years, 5 months ago by yzshen1
Modified:
8 years, 5 months ago
Reviewers:
csilv, Dan Beam
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix the issue that Flash-related options are not showed on Chrome OS. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146265

Patch Set 1 #

Patch Set 2 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M chrome/browser/ui/webui/options2/chromeos/core_chromeos_options_handler.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/core_chromeos_options_handler.cc View 1 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
yzshen1
Hi, Dan. Would you please take a look? Thanks!
8 years, 5 months ago (2012-07-10 21:10:55 UTC) #1
Dan Beam
lgtm with green try runs / no huge number of crashes, :)
8 years, 5 months ago (2012-07-10 21:13:21 UTC) #2
yzshen1
On 2012/07/10 21:13:21, Dan Beam wrote: > lgtm with green try runs / no huge ...
8 years, 5 months ago (2012-07-10 21:16:56 UTC) #3
Dan Beam
I'm an OWNER as of quite recently, btw - http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options2/OWNERS?view=markup
8 years, 5 months ago (2012-07-10 21:17:53 UTC) #4
yzshen1
On 2012/07/10 21:17:53, Dan Beam wrote: > I'm an OWNER as of quite recently, btw ...
8 years, 5 months ago (2012-07-10 21:20:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/10692141/1
8 years, 5 months ago (2012-07-10 21:20:49 UTC) #6
csilv
lgtm
8 years, 5 months ago (2012-07-10 21:31:29 UTC) #7
commit-bot: I haz the power
Try job failure for 10692141-1 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 5 months ago (2012-07-10 23:02:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/10692141/1
8 years, 5 months ago (2012-07-11 06:25:45 UTC) #9
commit-bot: I haz the power
Failed to apply patch for chrome/browser/ui/webui/options2/chromeos/core_chromeos_options_handler2.cc: While running patch -p1 --forward --force; patching file chrome/browser/ui/webui/options2/chromeos/core_chromeos_options_handler2.cc ...
8 years, 5 months ago (2012-07-11 08:39:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/10692141/4004
8 years, 5 months ago (2012-07-12 00:16:38 UTC) #11
commit-bot: I haz the power
8 years, 5 months ago (2012-07-12 01:49:23 UTC) #12
Change committed as 146265

Powered by Google App Engine
This is Rietveld 408576698