Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 10692123: Implement RegisterComponent method call. (Closed)

Created:
8 years, 5 months ago by Seigo Nonaka
Modified:
8 years, 5 months ago
Reviewers:
ivan, satorux1
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Implement RegisterComponent method call. RegisterComponent method call is used when the engine object register itself to ibus-daemon. BUG=126947 TEST=ran chromeos_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145833

Patch Set 1 : CL for review #

Total comments: 2

Patch Set 2 : Add override comment. #

Patch Set 3 : Fix miss rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -1 line) Patch
M chromeos/dbus/ibus/ibus_client.h View 3 chunks +12 lines, -0 lines 0 comments Download
M chromeos/dbus/ibus/ibus_client.cc View 1 2 5 chunks +48 lines, -0 lines 0 comments Download
M chromeos/dbus/ibus/mock_ibus_client.h View 1 2 chunks +25 lines, -1 line 0 comments Download
M chromeos/dbus/ibus/mock_ibus_client.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Seigo Nonaka
8 years, 5 months ago (2012-07-09 16:41:38 UTC) #1
satorux1
LGTM https://chromiumcodereview.appspot.com/10692123/diff/9001/chromeos/dbus/ibus/mock_ibus_client.h File chromeos/dbus/ibus/mock_ibus_client.h (right): https://chromiumcodereview.appspot.com/10692123/diff/9001/chromeos/dbus/ibus/mock_ibus_client.h#newcode29 chromeos/dbus/ibus/mock_ibus_client.h:29: virtual void CreateInputContext(const std::string& client_name, Please add: // ...
8 years, 5 months ago (2012-07-09 16:44:00 UTC) #2
Seigo Nonaka
Thank you for your quick review. I will submit after checking try bot just in ...
8 years, 5 months ago (2012-07-09 16:51:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/10692123/8002
8 years, 5 months ago (2012-07-10 01:31:21 UTC) #4
commit-bot: I haz the power
Change committed as 145833
8 years, 5 months ago (2012-07-10 02:45:48 UTC) #5
ivan_cobs.com.sg
8 years, 5 months ago (2012-07-10 03:46:19 UTC) #6
Pls remove the following email adds from your list NOW

ivan@cobs.com.sg
lynn@cobs.com.sg

-----Original Message-----
From: commit-bot@chromium.org [mailto:commit-bot@chromium.org] 
Sent: Tuesday, 10 July, 2012 10:46 AM
To: nona@chromium.org; satorux@chromium.org
Cc: chromium-reviews@chromium.org; stevenjb+watch@chromium.org;
oshima+watch@chromium.org
Subject: [chromium-reviews] Re: Implement RegisterComponent method call.
(issue 10692123)

Change committed as 145833

https://chromiumcodereview.appspot.com/10692123/

Powered by Google App Engine
This is Rietveld 408576698