Issue 10692111: Added forced network scan to network dropdown.

Issue 10692111: Added forced network scan to network dropdown. (Closed)

Created:
8 years, 5 months ago by ygorshenin1

Modified:
8 years, 5 months ago

Reviewers:
Ivan Korotkov

CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org, dcheng, nkostylev+watch_chromium.org, Nikita (slow)

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Added forced network scan to network dropdown. BUG=133988 TEST=manual testing on the Alex device Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145601

Patch Set 2 : Sync, small fix. #

Patch Set 3 : Added comment to NetworkDropdown::ForceNetworkScan #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -1 line)			Patch
	M	chrome/browser/ui/webui/chromeos/login/network_dropdown.h	View	1 2	3 chunks	+9 lines, -1 line	0 comments	Download
	M	chrome/browser/ui/webui/chromeos/login/network_dropdown.cc	View	1	4 chunks	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ygorshenin1

The problem was because on the network screen network scan was performed only once. After ...

8 years, 5 months ago (2012-07-06 14:54:07 UTC) #1

Ivan Korotkov

lgtm http://codereview.chromium.org/10692111/diff/1/chrome/browser/ui/webui/chromeos/login/network_dropdown.h File chrome/browser/ui/webui/chromeos/login/network_dropdown.h (right): http://codereview.chromium.org/10692111/diff/1/chrome/browser/ui/webui/chromeos/login/network_dropdown.h#newcode56 chrome/browser/ui/webui/chromeos/login/network_dropdown.h:56: void ForceNetworkScan(); Please comment.

8 years, 5 months ago (2012-07-06 15:27:31 UTC) #2

ygorshenin1

Thanks! http://codereview.chromium.org/10692111/diff/1/chrome/browser/ui/webui/chromeos/login/network_dropdown.h File chrome/browser/ui/webui/chromeos/login/network_dropdown.h (right): http://codereview.chromium.org/10692111/diff/1/chrome/browser/ui/webui/chromeos/login/network_dropdown.h#newcode56 chrome/browser/ui/webui/chromeos/login/network_dropdown.h:56: void ForceNetworkScan(); On 2012/07/06 15:27:31, Ivan Korotkov wrote: ...

8 years, 5 months ago (2012-07-06 15:34:55 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/10692111/9001

8 years, 5 months ago (2012-07-06 16:21:22 UTC) #4

Change committed as 145601

Expand Messages | Collapse Messages