Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: vm/intermediate_language.cc

Issue 10692107: Add forward iterator to iterate instructions inside a basic block. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« vm/intermediate_language.h ('K') | « vm/intermediate_language.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/intermediate_language.cc
===================================================================
--- vm/intermediate_language.cc (revision 9430)
+++ vm/intermediate_language.cc (working copy)
@@ -527,37 +527,6 @@
}
-Instruction* Instruction::RemoveFromGraph() {
- ASSERT(!IsBlockEntry());
- ASSERT(!IsBranch());
- ASSERT(!IsThrow());
- ASSERT(!IsReturn());
- ASSERT(!IsReThrow());
- ASSERT(previous() != NULL);
- Instruction* next = successor();
- previous()->set_successor(next);
- if (next != NULL) {
- if (!next->IsBlockEntry()) {
- next->set_previous(previous());
- } else {
- // Removing the last instruction of a block.
- // Update last_instruction of the current basic block.
- Instruction* current = this;
- while (!current->IsBlockEntry()) {
- current = current->previous();
- }
- ASSERT(current->AsBlockEntry()->last_instruction() == this);
- current->AsBlockEntry()->set_last_instruction(previous());
- }
- }
- // Reset successor and previous instruction to indicate
- // that the instruction is removed from the graph.
- set_successor(NULL);
- set_previous(NULL);
- return next;
-}
-
-
intptr_t GraphEntryInstr::SuccessorCount() const {
return 1 + catch_entries_.length();
}
« vm/intermediate_language.h ('K') | « vm/intermediate_language.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698