Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Unified Diff: chrome/common/extensions/api/file_system.idl

Issue 10692105: Updates file type selector for fileSystem API (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Experiment with IDL file; longer comments so it's clearer what the goal is Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/file_system/file_system_api.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/api/file_system.idl
diff --git a/chrome/common/extensions/api/file_system.idl b/chrome/common/extensions/api/file_system.idl
index 7d9928eb7456edceb02499f1f9987ba1c4a8c938..3f913e205ef66c959ab4f6d44ea00354dbf7694e 100644
--- a/chrome/common/extensions/api/file_system.idl
+++ b/chrome/common/extensions/api/file_system.idl
@@ -18,6 +18,27 @@ namespace fileSystem {
//
// The default is 'openFile'.
DOMString? type;
+
+ // The suggested file name that will be presented to the user as the
+ // default name to read or write. This is optional.
+ DOMString? suggestedPath;
benwells 2012/07/12 06:10:57 Cool :) Feel free to do in a separate patch, or in
thorogood 2012/07/13 04:17:27 Done in other patch.
+
+ // The optional list of accepted mime-types for this file opener, grouped
+ // by type.
+ //
+ // For example, ['image/*', 'application/json,.jso'] would display two type
benwells 2012/07/12 06:10:57 This is not nitting on the text, just me trying to
thorogood 2012/07/13 04:17:27 Yes, that's right. The aim here is to allow for al
+ // options - one accepting images - and the other accepting json files and
+ // those with the extension 'jso'.
+ //
+ // This field is optional. However, it is an error to not specify this
+ // field (or pass an empty array) but pass acceptsAllTypes as false.
+ DOMString[]? accepts;
+
+ // Does this file picker accept all file types, in addition to the options
+ // specified in the accepts argument?
benwells 2012/07/12 06:10:57 Nit: don't phrase as a question.
thorogood 2012/07/13 04:17:27 Done.
+ //
+ // The default is true.
+ boolean? acceptsAllTypes;
};
callback GetDisplayPathCallback = void (DOMString displayPath);
callback FileEntryCallback = void ([instanceOf=fileEntry] object fileEntry);
« no previous file with comments | « chrome/browser/extensions/api/file_system/file_system_api.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698