Updates file type selector for fileSystem API

chrome/browser/extensions/api/file_system/file_system_api.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_FILE_SYSTEM_FILE_SYSTEM_API_H_
 #define CHROME_BROWSER_EXTENSIONS_API_FILE_SYSTEM_FILE_SYSTEM_API_H_
 
 #include "chrome/browser/extensions/extension_function.h"
+#include "chrome/common/extensions/api/file_system.h"
 #include "ui/base/dialogs/select_file_dialog.h"
 
+namespace file_system = extensions::api::file_system;

[Mihai Parparita -not on Chrome, 2012/07/31 22:26:10]

Namespace aliases aren't allowed in the top level of header files (see
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Namesp...).
You can move it inside of the "extension" namespace, though by that point you're
not really gaining much, shorthand-wise. Maybe don't use the alias in the header
file, and add a "namespace AcceptOption =
extensions::api::file_system::AcceptOption" in the .cc file, to make things even
shorter.

[benwells, 2012/07/31 23:01:19]

You could also have a typedef in FileSystemChooseFileFunction for the vector of
linked ptrs of extension::api::file_system::AcceptOptions.

[thorogood, 2012/08/03 02:58:02]

I've taken the typedef option inside the class definition - it seems neat.

+
 namespace extensions {
 
 class FileSystemGetDisplayPathFunction : public SyncExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION_NAME("fileSystem.getDisplayPath");
 
  protected:
   virtual ~FileSystemGetDisplayPathFunction() {}
   virtual bool RunImpl() OVERRIDE;
 };
@@ skipping 44 matching lines @@
 
 class FileSystemChooseFileFunction : public FileSystemEntryFunction {
  public:
   // Allow picker UI to be skipped in testing.
   static void SkipPickerAndAlwaysSelectPathForTest(FilePath* path);
   static void SkipPickerAndAlwaysCancelForTest();
   static void StopSkippingPickerForTest();
 
   DECLARE_EXTENSION_FUNCTION_NAME("fileSystem.chooseFile");
 
+  static void BuildFileTypeInfo(
+      ui::SelectFileDialog::FileTypeInfo* file_type_info,
+      const FilePath::StringType& suggested_extension,
+      const std::vector<linked_ptr<file_system::AcceptOption> >* accepts,
+      const bool* acceptsAllTypes);
+  static void BuildSuggestion(const std::string* opt_name,
+                              FilePath* suggested_name,
+                              FilePath::StringType* suggested_extension);
+
  protected:
   class FilePicker;
 
   virtual ~FileSystemChooseFileFunction() {}
   virtual bool RunImpl() OVERRIDE;
   bool ShowPicker(const FilePath& suggested_path,
+                  const ui::SelectFileDialog::FileTypeInfo& file_type_info,
                   ui::SelectFileDialog::Type picker_type,
                   EntryType entry_type);
 
  private:
   // FileSelected and FileSelectionCanceled are called by the file picker.
   void FileSelected(const FilePath& path, EntryType entry_type);
   void FileSelectionCanceled();
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_FILE_SYSTEM_FILE_SYSTEM_API_H_