chrome/renderer/resources/extensions/file_system_custom_bindings.js - Issue 10692104: Add isWritableFileEntry to the fileSystem API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/file_system_custom_bindings.js

Issue 10692104: Add isWritableFileEntry to the fileSystem API (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: added presubmit fix Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/file_system.idl ('k') | chrome/test/data/extensions/api_test/file_system/get_writable_file_entry/test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/file_system_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/file_system_custom_bindings.js b/chrome/renderer/resources/extensions/file_system_custom_bindings.js

index 42487875c8658c0d0571b4672297df5fbde430d8..0f2b9f4e234e4f4d480352a5ef163548145586c7 100644

--- a/chrome/renderer/resources/extensions/file_system_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/file_system_custom_bindings.js

@@ -19,7 +19,8 @@ chromeHidden.registerCustomHook('fileSystem', function(bindingsAPI) {

return [fileSystemName, relativePath, callback];

});

}

- ['getDisplayPath', 'getWritableFileEntry'].forEach(bindFileEntryFunction);

+ ['getDisplayPath', 'getWritableFileEntry', 'isWritableFileEntry']

+ .forEach(bindFileEntryFunction);

function bindFileEntryCallback(functionName) {

apiFunctions.setCustomCallback(functionName,