chrome/common/extensions/PRESUBMIT.py - Issue 10692104: Add isWritableFileEntry to the fileSystem API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/PRESUBMIT.py

Issue 10692104: Add isWritableFileEntry to the fileSystem API (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: added presubmit fix Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/PRESUBMIT.py

diff --git a/chrome/common/extensions/PRESUBMIT.py b/chrome/common/extensions/PRESUBMIT.py

index 8dc898968db59185bb37a1eee59de7269e4fe567..b621d4b658380159007497dabf0fb7794602b083 100644

--- a/chrome/common/extensions/PRESUBMIT.py

+++ b/chrome/common/extensions/PRESUBMIT.py

@@ -87,7 +87,7 @@ def IsSkippedFile(path, input_api):

def IsApiFile(path, input_api):

return (input_api.os_path.dirname(path) == API_DIR and

- path.endswith('.json'))

+ (path.endswith('.json') or path.endswith('.idl')))

def IsBuildFile(path, input_api):

return input_api.os_path.dirname(path) == BUILD_DIR