Fix int.compareTo.

tests/corelib/compare_to_test.dart

+// Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+// Dart test for testing Math.min and Math.max.
+
+main() {
+  // Test matrix:

[Lasse Reichstein Nielsen, 2012/07/06 08:56:17]

You need bigger numbers. Try adding +/- 2^53, 2^53+1, 2^2000, 2^2000 + 1.
(I.e., integers that don't convert well to doubles, either by losing precision
or by becoming infinity).
Also have double numbers that aren't integers, preferably all of:
 min-non-zero: 5e-324
 max denormal: 2.225073858507201e-308
 min normal: 2.2250738585072014e-308
 max fraction: 0.9999999999999999
 one: 1.0
 min above 1: 1.0000000000000002
 max non-int: 4503599627370495.5
and for completeness, these numbers as both doubles and integers:
 Max exact int: 9007199254740992.0
 Max finite: 1.7976931348623157e+308
and the higher values integers.

You might want to make loops to do these comparisons. E.g., put all the values
into an array of arrays, in order with equal values in the same sub-array.

[floitsch, 2012/07/06 13:18:55]

Done.

+  // -inf < -499.0 == -499 < -0.0 < 0.0 == 0 < 499.0 == 499 < +inf < NaN.
+  var inf = double.INFINITY;
+  var nan = double.NAN;
+
+  Expect.equals(0, (-inf).compareTo(-inf));
+  Expect.equals(-1, (-inf).compareTo(-499.0));
+  Expect.equals(-1, (-inf).compareTo(-499));
+  Expect.equals(-1, (-inf).compareTo(-0.0));
+  Expect.equals(-1, (-inf).compareTo(0));
+  Expect.equals(-1, (-inf).compareTo(0.0));
+  Expect.equals(-1, (-inf).compareTo(499.0));
+  Expect.equals(-1, (-inf).compareTo(499));
+  Expect.equals(-1, (-inf).compareTo(inf));
+  Expect.equals(-1, (-inf).compareTo(nan));
+
+  Expect.equals(1, (-499.0).compareTo(-inf));
+  Expect.equals(0, (-499.0).compareTo(-499.0));
+  Expect.equals(0, (-499.0).compareTo(-499));
+  Expect.equals(-1, (-499.0).compareTo(-0.0));
+  Expect.equals(-1, (-499.0).compareTo(0));
+  Expect.equals(-1, (-499.0).compareTo(0.0));
+  Expect.equals(-1, (-499.0).compareTo(499.0));
+  Expect.equals(-1, (-499.0).compareTo(499));
+  Expect.equals(-1, (-499.0).compareTo(inf));
+  Expect.equals(-1, (-499.0).compareTo(nan));
+
+  Expect.equals(1, (-499).compareTo(-inf));
+  Expect.equals(0, (-499).compareTo(-499.0));
+  Expect.equals(0, (-499).compareTo(-499));
+  Expect.equals(-1, (-499).compareTo(-0.0));
+  Expect.equals(-1, (-499).compareTo(0));
+  Expect.equals(-1, (-499).compareTo(0.0));
+  Expect.equals(-1, (-499).compareTo(499.0));
+  Expect.equals(-1, (-499).compareTo(499));
+  Expect.equals(-1, (-499).compareTo(inf));
+  Expect.equals(-1, (-499).compareTo(nan));
+
+  Expect.equals(1, (-0.0).compareTo(-inf));
+  Expect.equals(1, (-0.0).compareTo(-499.0));
+  Expect.equals(1, (-0.0).compareTo(-499));
+  Expect.equals(0, (-0.0).compareTo(-0.0));
+  Expect.equals(-1, (-0.0).compareTo(0));
+  Expect.equals(-1, (-0.0).compareTo(0.0));
+  Expect.equals(-1, (-0.0).compareTo(499.0));
+  Expect.equals(-1, (-0.0).compareTo(499));
+  Expect.equals(-1, (-0.0).compareTo(inf));
+  Expect.equals(-1, (-0.0).compareTo(nan));
+
+  Expect.equals(1, (0).compareTo(-inf));
+  Expect.equals(1, (0).compareTo(-499.0));
+  Expect.equals(1, (0).compareTo(-499));
+  Expect.equals(1, (0).compareTo(-0.0));
+  Expect.equals(0, (0).compareTo(0));
+  Expect.equals(0, (0).compareTo(0.0));
+  Expect.equals(-1, (0).compareTo(499.0));
+  Expect.equals(-1, (0).compareTo(499));
+  Expect.equals(-1, (0).compareTo(inf));
+  Expect.equals(-1, (0).compareTo(nan));
+
+  Expect.equals(1, (0.0).compareTo(-inf));
+  Expect.equals(1, (0.0).compareTo(-499.0));
+  Expect.equals(1, (0.0).compareTo(-499));
+  Expect.equals(1, (0.0).compareTo(-0.0));
+  Expect.equals(0, (0.0).compareTo(0));
+  Expect.equals(0, (0.0).compareTo(0.0));
+  Expect.equals(-1, (0.0).compareTo(499.0));
+  Expect.equals(-1, (0.0).compareTo(499));
+  Expect.equals(-1, (0.0).compareTo(inf));
+  Expect.equals(-1, (0.0).compareTo(nan));
+
+  Expect.equals(1, (499.0).compareTo(-inf));
+  Expect.equals(1, (499.0).compareTo(-499.0));
+  Expect.equals(1, (499.0).compareTo(-499));
+  Expect.equals(1, (499.0).compareTo(-0.0));
+  Expect.equals(1, (499.0).compareTo(0));
+  Expect.equals(1, (499.0).compareTo(0.0));
+  Expect.equals(0, (499.0).compareTo(499.0));
+  Expect.equals(0, (499.0).compareTo(499));
+  Expect.equals(-1, (499.0).compareTo(inf));
+  Expect.equals(-1, (499.0).compareTo(nan));
+
+  Expect.equals(1, (499).compareTo(-inf));
+  Expect.equals(1, (499).compareTo(-499.0));
+  Expect.equals(1, (499).compareTo(-499));
+  Expect.equals(1, (499).compareTo(-0.0));
+  Expect.equals(1, (499).compareTo(0));
+  Expect.equals(1, (499).compareTo(0.0));
+  Expect.equals(0, (499).compareTo(499.0));
+  Expect.equals(0, (499).compareTo(499));
+  Expect.equals(-1, (499).compareTo(inf));
+  Expect.equals(-1, (499).compareTo(nan));
+
+  Expect.equals(1, inf.compareTo(-inf));
+  Expect.equals(1, inf.compareTo(-499.0));
+  Expect.equals(1, inf.compareTo(-499));
+  Expect.equals(1, inf.compareTo(-0.0));
+  Expect.equals(1, inf.compareTo(0));
+  Expect.equals(1, inf.compareTo(0.0));
+  Expect.equals(1, inf.compareTo(499.0));
+  Expect.equals(1, inf.compareTo(499));
+  Expect.equals(0, inf.compareTo(inf));
+  Expect.equals(-1, inf.compareTo(nan));
+
+  Expect.equals(1, nan.compareTo(-inf));
+  Expect.equals(1, nan.compareTo(-499.0));
+  Expect.equals(1, nan.compareTo(-499));
+  Expect.equals(1, nan.compareTo(-0.0));
+  Expect.equals(1, nan.compareTo(0));
+  Expect.equals(1, nan.compareTo(0.0));
+  Expect.equals(1, nan.compareTo(499.0));
+  Expect.equals(1, nan.compareTo(499));
+  Expect.equals(1, nan.compareTo(inf));
+  Expect.equals(0, nan.compareTo(nan));
+}