Introduce webNavigation.onTabReplaced event that is fired when a tab from instant or prerender repl…

Introduce webNavigation.onTabReplaced event that is fired when a tab from instant or prerender replaces the current tab

BUG=117043, 136090
TEST=manually using the webNavigation example extension

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145646

[jochen (gone - plz use gerrit), 2012-07-05 12:55:56]

plz review

[battre, 2012-07-05 15:38:46]

LGTM if the comment in web_navigation_api.cc is not an issue.

https://chromiumcodereview.appspot.com/10692097/diff/1/chrome/browser/extensi...
File chrome/browser/extensions/api/web_navigation/web_navigation_api.cc (right):

https://chromiumcodereview.appspot.com/10692097/diff/1/chrome/browser/extensi...
chrome/browser/extensions/api/web_navigation/web_navigation_api.cc:421:
WebNavigationEventRouter::~WebNavigationEventRouter() {}
The WebNavigationEventRouter is owned by the ExtensionService. I *suppose* that
it gets destroyed before the static browser list. Should we call
BrowserList::RemoveObserver(this) here?

https://chromiumcodereview.appspot.com/10692097/diff/1/chrome/common/extensio...
File chrome/common/extensions/api/web_navigation.json (right):

https://chromiumcodereview.appspot.com/10692097/diff/1/chrome/common/extensio...
chrome/common/extensions/api/web_navigation.json:264: "sourceTabId": {"type":
"integer", "description": "The ID of the tab that was replaced."},
Should this be called "oldTabId"? How does "source" connect to a replacement?

https://chromiumcodereview.appspot.com/10692097/diff/1/chrome/common/extensio...
chrome/common/extensions/api/web_navigation.json:265: "tabId": {"type":
"integer", "description": "The ID of the tab that replaced the old tab."},
If the previous one becomes oldTabId, this might become newTabId.

https://chromiumcodereview.appspot.com/10692097/diff/1/chrome/common/extensio...
File chrome/common/extensions/docs/static/webNavigation.html (right):

https://chromiumcodereview.appspot.com/10692097/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/static/webNavigation.html:63: If a navigation was
done via <a
s/done/triggered/?

[jochen (gone - plz use gerrit), 2012-07-06 11:13:50]

https://chromiumcodereview.appspot.com/10692097/diff/1/chrome/browser/extensi...
File chrome/browser/extensions/api/web_navigation/web_navigation_api.cc (right):

https://chromiumcodereview.appspot.com/10692097/diff/1/chrome/browser/extensi...
chrome/browser/extensions/api/web_navigation/web_navigation_api.cc:421:
WebNavigationEventRouter::~WebNavigationEventRouter() {}
On 2012/07/05 15:38:46, battre wrote:
> The WebNavigationEventRouter is owned by the ExtensionService. I *suppose*
that
> it gets destroyed before the static browser list. Should we call
> BrowserList::RemoveObserver(this) here?

Done.

https://chromiumcodereview.appspot.com/10692097/diff/1/chrome/common/extensio...
File chrome/common/extensions/api/web_navigation.json (right):

https://chromiumcodereview.appspot.com/10692097/diff/1/chrome/common/extensio...
chrome/common/extensions/api/web_navigation.json:264: "sourceTabId": {"type":
"integer", "description": "The ID of the tab that was replaced."},
On 2012/07/05 15:38:46, battre wrote:
> Should this be called "oldTabId"? How does "source" connect to a replacement?

What about replacedTabId

https://chromiumcodereview.appspot.com/10692097/diff/1/chrome/common/extensio...
chrome/common/extensions/api/web_navigation.json:265: "tabId": {"type":
"integer", "description": "The ID of the tab that replaced the old tab."},
On 2012/07/05 15:38:46, battre wrote:
> If the previous one becomes oldTabId, this might become newTabId.

I'd prefer to call this tabId, to be consistent with the other events (compare
onCreatedNavigationTarget)

https://chromiumcodereview.appspot.com/10692097/diff/1/chrome/common/extensio...
File chrome/common/extensions/docs/static/webNavigation.html (right):

https://chromiumcodereview.appspot.com/10692097/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/static/webNavigation.html:63: If a navigation was
done via <a
On 2012/07/05 15:38:46, battre wrote:
> s/done/triggered/?

Done.

[battre, 2012-07-06 11:18:13]

https://chromiumcodereview.appspot.com/10692097/diff/1/chrome/common/extensio...
File chrome/common/extensions/api/web_navigation.json (right):

https://chromiumcodereview.appspot.com/10692097/diff/1/chrome/common/extensio...
chrome/common/extensions/api/web_navigation.json:264: "sourceTabId": {"type":
"integer", "description": "The ID of the tab that was replaced."},
On 2012/07/06 11:13:50, jochen wrote:
> On 2012/07/05 15:38:46, battre wrote:
> > Should this be called "oldTabId"? How does "source" connect to a
replacement?
> 
> What about replacedTabId

SGTM

[commit-bot: I haz the power, 2012-07-06 11:56:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/10692097/1

[commit-bot: I haz the power, 2012-07-06 11:56:19]

Presubmit check for 10692097-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
This change modifies the extension docs but the generated docs have not been
updated properly. See chrome/common/extensions/docs/README.txt for more info.
 - Changes to chrome/common/extensions/docs/static/webNavigation.html not
reflected in generated doc.
First build DumpRenderTree, then update the docs by running:
  chrome/common/extensions/docs/build/build.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/common/extensions/api

[jochen (gone - plz use gerrit), 2012-07-06 14:16:45]

+koz for OWNERS

[koz (OOO until 15th September), 2012-07-07 03:50:51]

lgtm