Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(824)

Issue 10692093: Use Chrome version for cloud print binaries. (Closed)

Created:
8 years, 5 months ago by Vitaly Buka (NO REVIEWS)
Modified:
8 years, 5 months ago
Reviewers:
Albert Bodenhamer
CC:
chromium-reviews
Visibility:
Public.

Description

Use Chrome version for cloud print targets. BUG=none TEST=none

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -108 lines) Patch
M cloud_print/service/service.gyp View 1 2 chunks +11 lines, -0 lines 0 comments Download
M cloud_print/service/win/cloud_print_service.rc View 1 1 chunk +105 lines, -104 lines 0 comments Download
M cloud_print/virtual_driver/win/install/virtual_driver_install.gyp View 1 chunk +5 lines, -0 lines 0 comments Download
M cloud_print/virtual_driver/win/virtual_driver.gypi View 1 chunk +5 lines, -0 lines 0 comments Download
M cloud_print/virtual_driver/win/virtual_driver_common_resources.rc View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Vitaly Buka (NO REVIEWS)
8 years, 5 months ago (2012-07-05 07:56:03 UTC) #1
Vitaly Buka (NO REVIEWS)
8 years, 5 months ago (2012-07-05 07:56:17 UTC) #2
Albert Bodenhamer
lgtm
8 years, 5 months ago (2012-07-09 04:02:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10692093/7002
8 years, 5 months ago (2012-07-09 18:43:03 UTC) #4
commit-bot: I haz the power
Failed to apply patch for cloud_print/service/win/cloud_print_service.rc: While running patch -p1 --forward --force; patching file cloud_print/service/win/cloud_print_service.rc ...
8 years, 5 months ago (2012-07-09 18:43:14 UTC) #5
Vitaly Buka (NO REVIEWS)
8 years, 5 months ago (2012-07-09 19:54:47 UTC) #6

Powered by Google App Engine
This is Rietveld 408576698