Issue 10692077: enable -Wunused-private-field for linux and chromeos.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10692077: enable -Wunused-private-field for linux and chromeos. (Closed)

Created:
8 years, 5 months ago by tony

Modified:
8 years, 5 months ago

Reviewers:
Nico, sadrul, Ryan Sleevi

CC:
chromium-reviews, nkostylev+watch_chromium.org, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

enable -Wunused-private-field for linux and chromeos. BUG=None TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145395

Patch Set 1 #

Patch Set 2 : chromeos fixes #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -20 lines)			Patch
M	build/common.gypi	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_engine.cc	View		2 chunks	+1 line, -8 lines	0 comments	Download
M	chrome/browser/chromeos/process_proxy/process_proxy_browsertest.cc	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/api/bluetooth/bluetooth_apitest_chromeos.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/views/window/client_view.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	ui/views/window/client_view.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

tony

This is a follow up to http://codereview.chromium.org/10698081/ .

8 years, 5 months ago (2012-07-03 21:01:37 UTC) #1

tony

Err, by follow up, I mean a 'replacement for' since Nico is on vacation now.

8 years, 5 months ago (2012-07-03 21:01:56 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/10692077/3001

8 years, 5 months ago (2012-07-03 21:14:14 UTC) #5

Thanks!!

Expand Messages | Collapse Messages