Issue 10692074: Stop autologin when the WebContents is destroyed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10692074: Stop autologin when the WebContents is destroyed. (Closed)

Created:
8 years, 5 months ago by qsr

Modified:
8 years, 5 months ago

Reviewers:
sky, Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Stop autologin when the WebContents is destroyed. A crash can happen when the token is received after the NavigationController is destroyed. This change prevents this by listening to WebContents being destroyed. BUG=None TEST=None R=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145903

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -1 line)			Patch
	M	chrome/browser/ui/auto_login_info_bar_delegate.cc	View		4 chunks	+24 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/10692074/1

8 years, 5 months ago (2012-07-10 15:18:56 UTC) #4

Change committed as 145903

Expand Messages | Collapse Messages