Issue 10692043: Consolidate similar KeyedLoads to worst case instead of transitioning elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10692043: Consolidate similar KeyedLoads to worst case instead of transitioning elements (Closed)

Created:
8 years, 5 months ago by danno

Modified:
8 years, 5 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Consolidate similar KeyedLoads to worst case instead of transitioning elements R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=11959

Patch Set 1 #

Patch Set 2 : Refactor into separate function #

Patch Set 3 : Whitespace and comment tweaks #

Total comments: 6

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -5 lines)			Patch
	M	src/hydrogen.h	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
	M	src/hydrogen.cc	View	1 2	4 chunks	+86 lines, -5 lines	6 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with nits. I'd like it even more if instead of having the HCheckMaps we'd ...

8 years, 5 months ago (2012-06-29 18:42:41 UTC) #2

danno

8 years, 5 months ago (2012-07-02 11:07:14 UTC) #3

Landed.

http://codereview.chromium.org/10692043/diff/4001/src/hydrogen.cc
File src/hydrogen.cc (right):

http://codereview.chromium.org/10692043/diff/4001/src/hydrogen.cc#newcode5861
src/hydrogen.cc:5861: new(zone()) HCheckMaps(object, maps, zone());
On 2012/06/29 18:42:41, Jakob wrote:
> nit: fits on one line

Done.

http://codereview.chromium.org/10692043/diff/4001/src/hydrogen.cc#newcode5865
src/hydrogen.cc:5865: check_maps, most_general_consolidated_map, false);
On 2012/06/29 18:42:41, Jakob wrote:
> nit: fits on the same line as "object, key, val".

Done.

http://codereview.chromium.org/10692043/diff/4001/src/hydrogen.cc#newcode5949
src/hydrogen.cc:5949: : BuildLoadKeyedGeneric(object, key));
On 2012/06/29 18:42:41, Jakob wrote:
> nit: why this change?

Done.

Expand Messages | Collapse Messages