Reapply r9192 and 9194, with the change of making locale a public field.

lib/i18n/date_format.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * DateFormat is for formatting and parsing dates in a locale-sensitive
  * manner.
  * It allows the user to choose from a set of standard date time formats as well
  * as specify a customized pattern under certain locales. Date elements that
  * vary across locales include month name, week name, field order, etc.
@@ skipping 53 matching lines @@
  * instance, characters like ':', '.', ' ', '#' and '@' will appear in the
  * resulting time text even they are not embraced within single quotes. In our
  * current pattern usage, we didn't use up all letters. But those unused
  * letters are strongly discouraged to be used as quoted text without quote.
  * That's because we may use other letter for pattern in future.
  *
  * Examples Using the US Locale:
  *
  *     Format Pattern                         Result
  *     --------------                         -------
- *     "yyyy.MM.dd G 'at' HH:mm:ss vvvv"->> 1996.07.10 AD at 15:08:56 Pacific Time
- *     "EEE, MMM d, ''yy"               ->> Wed, July 10, '96
- *     "h:mm a"                         ->> 12:08 PM
- *     "hh 'o''clock' a, zzzz"          ->> 12 o'clock PM, Pacific Daylight Time
- *     "K:mm a, vvv"                    ->> 0:00 PM, PT
- *     "yyyyy.MMMMM.dd GGG hh:mm aaa"   ->> 01996.July.10 AD 12:08 PM
+ *     "yyyy.MM.dd G 'at' HH:mm:ss vvvv"->1996.07.10 AD at 15:08:56 Pacific Time
+ *     "EEE, MMM d, ''yy"               ->Wed, July 10, '96
+ *     "h:mm a"                         ->12:08 PM
+ *     "hh 'o''clock' a, zzzz"          ->12 o'clock PM, Pacific Daylight Time
+ *     "K:mm a, vvv"                    ->0:00 PM, PT
+ *     "yyyyy.MMMMM.dd GGG hh:mm aaa"   ->01996.July.10 AD 12:08 PM
  *
  * When parsing a date string using the abbreviated year pattern ("yy"),
  * DateTimeParse must interpret the abbreviated year relative to some
  * century. It does this by adjusting dates to be within 80 years before and 20
  * years after the time the parse function is called. For example, using a
  * pattern of "MM/dd/yy" and a DateTimeParse instance created on Jan 1, 1997,
  * the string "01/11/12" would be interpreted as Jan 11, 2012 while the string
  * "05/04/64" would be interpreted as May 4, 1964. During parsing, only
  * strings consisting of exactly two digits, as defined by {@link
  * java.lang.Character#isDigit(char)}, will be parsed into the default
  * century. Any other numeric string, such as a one digit string, a three or
  * more digit string will be interpreted as its face value.
  *
  * If the year pattern does not have exactly two 'y' characters, the year is
  * interpreted literally, regardless of the number of digits. So using the
  * pattern "MM/dd/yyyy", "01/11/12" parses to Jan 11, 12 A.D.
  *
  * When numeric fields abut one another directly, with no intervening
  * delimiter characters, they constitute a run of abutting numeric fields. Such
  * runs are parsed specially. For example, the format "HHmmss" parses the input
  * text "123456" to 12:34:56, parses the input text "12345" to 1:23:45, and
  * fails to parse "1234". In other words, the leftmost field of the run is
  * flexible, while the others keep a fixed width. If the parse fails anywhere in
  * the run, then the leftmost field is shortened by one character, and the
  * entire run is parsed again. This is repeated until either the parse succeeds
  * or the leftmost field is one character in length. If the parse still fails at
  * that point, the parse of the run fails.
  */
 
-#library('date_format');
-
 class DateFormat {
 
   /** Definition of how this object formats dates. */
   String _formatDefinition;
 
   /**
    * The locale code with which the message is to be formatted (such as en-CA).
    */
   String _locale;
 
@@ skipping 43 matching lines @@
   static final String mediumTime = Hms;
   static final String shortTime = Hm;
   static final String fullDateTime = '$fullDate$fullTime';
   static final String longDateTime = '$longDate$longTime';
   static final String mediumDateTime = '$mediumDate$mediumTime';
   static final String shortDateTime = '$shortDate$shortTime';
 
   /**
    * Constructors for dates/times that use a default format.
    */
-  DateFormat.Hm([this._locale]) : _formatDefinition = Hm;
-  DateFormat.Hms([this._locale]) : _formatDefinition = Hms;
-  DateFormat.M([this._locale]) : _formatDefinition = M;
-  DateFormat.MEd([this._locale]) : _formatDefinition = MEd;
-  DateFormat.MMM([this._locale]) : _formatDefinition = MMM;
-  DateFormat.MMMEd([this._locale]) : _formatDefinition = MMMEd;
-  DateFormat.MMMMEd([this._locale]) : _formatDefinition = MMMMEd;
-  DateFormat.MMMMd([this._locale]) : _formatDefinition = MMMMd;
-  DateFormat.MMMd([this._locale]) : _formatDefinition = MMMd;
-  DateFormat.Md([this._locale]) : _formatDefinition = Md;
-  DateFormat.d([this._locale]) : _formatDefinition = d;
-  DateFormat.hm([this._locale]) : _formatDefinition = hm;
-  DateFormat.ms([this._locale]) : _formatDefinition = ms;
-  DateFormat.y([this._locale]) : _formatDefinition = y;
-  DateFormat.yM([this._locale]) : _formatDefinition = yM;
-  DateFormat.yMEd([this._locale]) : _formatDefinition = yMEd;
-  DateFormat.yMMM([this._locale]) : _formatDefinition = yMMM;
-  DateFormat.yMMMEd([this._locale]) : _formatDefinition = yMMMEd;
-  DateFormat.yMMMM([this._locale]) : _formatDefinition = yMMMM;
-  DateFormat.yQ([this._locale]) : _formatDefinition = yQ;
-  DateFormat.yQQQ([this._locale]) : _formatDefinition = yQQQ;
+  DateFormat.Hm([locale='']) : _locale = locale, _formatDefinition = Hm;
+  DateFormat.Hms([locale='']) : _locale = locale, _formatDefinition = Hms;
+  DateFormat.M([locale='']) : _locale = locale, _formatDefinition = M;
+  DateFormat.MEd([locale='']) : _locale = locale, _formatDefinition = MEd;
+  DateFormat.MMM([locale='']) : _locale = locale, _formatDefinition = MMM;
+  DateFormat.MMMEd([locale='']) : _locale = locale, _formatDefinition = MMMEd;
+  DateFormat.MMMMEd([locale='']) : _locale = locale, _formatDefinition = MMMMEd;
+  DateFormat.MMMMd([locale='']) : _locale = locale, _formatDefinition = MMMMd;
+  DateFormat.MMMd([locale='']) : _locale = locale, _formatDefinition = MMMd;
+  DateFormat.Md([locale='']) : _locale = locale, _formatDefinition = Md;
+  DateFormat.d([locale='']) : _locale = locale, _formatDefinition = d;
+  DateFormat.hm([locale='']) : _locale = locale, _formatDefinition = hm;
+  DateFormat.ms([locale='']) : _locale = locale, _formatDefinition = ms;
+  DateFormat.y([locale='']) : _locale = locale, _formatDefinition = y;
+  DateFormat.yM([locale='']) : _locale = locale, _formatDefinition = yM;
+  DateFormat.yMEd([locale='']) : _locale = locale, _formatDefinition = yMEd;
+  DateFormat.yMMM([locale='']) : _locale = locale, _formatDefinition = yMMM;
+  DateFormat.yMMMEd([locale='']) : _locale = locale, _formatDefinition = yMMMEd;
+  DateFormat.yMMMM([locale='']) : _locale = locale, _formatDefinition = yMMMM;
+  DateFormat.yQ([locale='']) : _locale = locale, _formatDefinition = yQ;
+  DateFormat.yQQQ([locale='']) : _locale = locale, _formatDefinition = yQQQ;
 
-  DateFormat.fullDate([this._locale]) : _formatDefinition = fullDate;
-  DateFormat.longDate([this._locale]) : _formatDefinition = longDate;
-  DateFormat.mediumDate([this._locale]) : _formatDefinition = mediumDate;
-  DateFormat.shortDate([this._locale]) : _formatDefinition = shortDate;
-  DateFormat.fullTime([this._locale]) : _formatDefinition = fullTime;
-  DateFormat.longTime([this._locale]) : _formatDefinition = longTime;
-  DateFormat.mediumTime([this._locale]) : _formatDefinition = mediumTime;
-  DateFormat.shortTime([this._locale]) : _formatDefinition = shortTime;
-  DateFormat.fullDateTime([this._locale]) : _formatDefinition = fullDateTime;
-  DateFormat.longDateTime([this._locale]) : _formatDefinition = longDateTime;
-  DateFormat.mediumDateTime([this._locale]) : _formatDefinition = mediumDateTime;
-  DateFormat.shortDateTime([this._locale]) : _formatDefinition = shortDateTime;
+  DateFormat.fullDate([locale='']) : _locale = locale,
+      _formatDefinition = fullDate;
+  DateFormat.longDate([locale='']) : _locale = locale,
+      _formatDefinition = longDate;
+  DateFormat.mediumDate([locale='']) : _locale = locale,
+      _formatDefinition = mediumDate;
+  DateFormat.shortDate([locale='']) : _locale = locale,
+      _formatDefinition = shortDate;
+  DateFormat.fullTime([locale='']) : _locale = locale,
+      _formatDefinition = fullTime;
+  DateFormat.longTime([locale='']) : _locale = locale,
+      _formatDefinition = longTime;
+  DateFormat.mediumTime([locale='']) : _locale = locale,
+      _formatDefinition = mediumTime;
+  DateFormat.shortTime([locale='']) : _locale = locale,
+      _formatDefinition = shortTime;
+  DateFormat.fullDateTime([locale='']) : _locale = locale,
+      _formatDefinition = fullDateTime;
+  DateFormat.longDateTime([locale='']) : _locale = locale,
+      _formatDefinition = longDateTime;
+  DateFormat.mediumDateTime([locale='']) : _locale = locale,
+      _formatDefinition = mediumDateTime;
+  DateFormat.shortDateTime([locale='']) : _locale = locale,
+      _formatDefinition = shortDateTime;
 
   /**
    * Constructor accepts a [formatDefinition], which can be a String, one of the
    * predefined static forms, or a custom date format using the syntax described
    * above. An optional [locale] can be provided for specifics of the language
    * locale to be used, otherwise, we will attempt to infer it (acceptable if
    * Dart is running on the client, we can infer from the browser).
    */
-  DateFormat([formatDefinition = fullDate, locale]) {
+  DateFormat([formatDefinition = fullDate, locale = '']) {
     this._formatDefinition = formatDefinition;
     this._locale = locale;
   }
 
   /**
    * Given user input, attempt to parse the [inputString] into the anticipated
    * format.
    */
   String parse(String inputString) {
     return inputString;
@@ skipping 19 matching lines @@
 
   /**
    * Formats a string indicating how long ago (negative [duration]) or how far
    * in the future (positive [duration]) some time is with respect to a
    * reference [date].
    */
   String formatDurationFrom(Duration duration, Date date) {
     return '';
   }
 }