chrome/browser/ui/sync/one_click_signin_sync_starter.h - Issue 10692021: Remove browser::FindLastActiveWithProfile call in login_ui_service.cc by plumbing the Browser* thro…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sync/one_click_signin_sync_starter.h

Issue 10692021: Remove browser::FindLastActiveWithProfile call in login_ui_service.cc by plumbing the Browser* thro… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/sync/one_click_signin_helper.cc ('k') | chrome/browser/ui/sync/one_click_signin_sync_starter.cc » ('j') | chrome/browser/ui/webui/signin/login_ui_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/sync/one_click_signin_sync_starter.h

===================================================================

--- chrome/browser/ui/sync/one_click_signin_sync_starter.h (revision 144404)

+++ chrome/browser/ui/sync/one_click_signin_sync_starter.h (working copy)

@@ -10,7 +10,7 @@

#include "chrome/browser/signin/signin_tracker.h"

-class Profile;

+class Browser;

// Waits for successful singin notification from the signin manager and then

// starts the sync machine. Instances of this class delete themselves once

@@ -19,7 +19,7 @@

public:

enum StartSyncMode {SYNC_WITH_DEFAULT_SETTINGS, CONFIGURE_SYNC_FIRST };

- OneClickSigninSyncStarter(Profile* profile,

+ OneClickSigninSyncStarter(Browser* browser,

const std::string& session_index,

const std::string& email,

const std::string& password,

@@ -28,12 +28,12 @@

private:

virtual ~OneClickSigninSyncStarter();

- // content::SigninTracker::Observer override.

+ // SigninTracker::Observer override.

virtual void GaiaCredentialsValid() OVERRIDE;

virtual void SigninFailed(const GoogleServiceAuthError& error) OVERRIDE;

virtual void SigninSuccess() OVERRIDE;

- Profile* const profile_;

+ Browser* browser_;

SigninTracker signin_tracker_;

StartSyncMode start_mode_;