Issue 10690192: [Mac] Only attempt to replace a notification if the replacement_id is not empty.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10690192: [Mac] Only attempt to replace a notification if the replacement_id is not empty. (Closed)

Created:
8 years, 5 months ago by Robert Sesek

Modified:
8 years, 5 months ago

Reviewers:
jianli

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Mac] Only attempt to replace a notification if the replacement_id is not empty. This was causing notifications to be dismissed too quickly because replacement was being attempted for all notifications since the replacement_id was empty. BUG=134990 TEST=Go to http://www/~rsesek/html_notifications.html and click "Notify Me" three times. "onclose" should not show up in the log box. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146617

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	chrome/browser/notifications/notification_ui_manager_mac.mm	View		1 chunk	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/10690192/1

8 years, 5 months ago (2012-07-13 17:56:16 UTC) #3

Change committed as 146617

Expand Messages | Collapse Messages