Issue 10690178: MIPS: Ensure that all descriptors have a valid enumeration index, and replace NextEnumIndex with La…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10690178: MIPS: Ensure that all descriptors have a valid enumeration index, and replace NextEnumIndex with La… (Closed)

Created:
8 years, 5 months ago by palfia

Modified:
8 years, 5 months ago

Reviewers:
kisg, Paul Lind, danno, Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

MIPS: Ensure that all descriptors have a valid enumeration index, and replace NextEnumIndex with LastAdded. Port r12042 (ce65764e) Original commit message: The LastAdded points to the descriptor that was last added to the array. From the descriptor we can deduce the NextEnumerationIndex. This allows us to quickly find the property that we are transitioning to, which is necessary for transition-intensive code, eg JSON parsing. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=12076

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -3 lines)			Patch
M	src/mips/full-codegen-mips.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/mips/macro-assembler-mips.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

palfia

Please land together with the following CL to avoid build and test errors: https://chromiumcodereview.appspot.com/10692192/

8 years, 5 months ago (2012-07-12 21:35:32 UTC) #1

lgtm, I'll land that for you.

Expand Messages | Collapse Messages