Issue 10690177: Renamed chrome_auth to cloud_print.

Issue 10690177: Renamed chrome_auth to cloud_print. (Closed)

Created:
8 years, 5 months ago by Vitaly Buka (NO REVIEWS)

Modified:
8 years, 4 months ago

Reviewers:
Albert Bodenhamer, Mihai Parparita -not on Chrome, Nico, csilv

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Renamed chrome_auth to cloud_print. No functionality changed except naming. Server side changes already alive. BUG=137129 TEST=unittest Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149303

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -267 lines)			Patch
D	chrome/browser/extensions/api/chrome_auth_private/chrome_auth_private_api.h	View	1 2 3	1 chunk	+0 lines, -33 lines	0 comments	Download
D	chrome/browser/extensions/api/chrome_auth_private/chrome_auth_private_api.cc	View	1 2 3	1 chunk	+0 lines, -53 lines	0 comments	Download
D	chrome/browser/extensions/api/chrome_auth_private/chrome_auth_private_apitest.cc	View	1 2 3	1 chunk	+0 lines, -60 lines	0 comments	Download
A +	chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.h	View	1 2	3 chunks	+7 lines, -7 lines	0 comments	Download
A +	chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc	View	1 2	3 chunks	+5 lines, -5 lines	0 comments	Download
A +	chrome/browser/extensions/api/cloud_print_private/cloud_print_private_apitest.cc	View	1 2	4 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/extensions/extension_function_registry.cc	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/cloud_print_app/manifest.json	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser_extensions.gypi	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/api/_permission_features.json	View	1 2 3 4	2 chunks	+6 lines, -6 lines	0 comments	Download
D	chrome/common/extensions/api/chrome_auth_private.json	View	1 2 3	1 chunk	+0 lines, -48 lines	0 comments	Download
A +	chrome/common/extensions/api/cloud_print_private.json	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/api/extension_api.cc	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/docs/js/api_page_generator.js	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/permissions/api_permission.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/permissions/api_permission.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/permissions/permission_set_unittest.cc	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/common/extensions_api_resources.grd	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/test/data/extensions/api_test/chrome_auth_private/enable_chrome_connector/cloud_print_success_tests.html	View	1 2 3	1 chunk	+0 lines, -6 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/chrome_auth_private/enable_chrome_connector/cloud_print_success_tests.js	View	1 2 3	1 chunk	+0 lines, -21 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/cloud_print_private/enable_chrome_connector/cloud_print_success_tests.html	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/cloud_print_private/enable_chrome_connector/cloud_print_success_tests.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/permissions/optional/background.js	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

Vitaly Buka (NO REVIEWS)

Hi Mihai, please review the Cl as OWNER.

8 years, 4 months ago (2012-07-31 20:15:44 UTC) #3

Mihai Parparita -not on Chrome

LGTM https://chromiumcodereview.appspot.com/10690177/diff/16004/chrome/common/extensions/api/_permission_features.json File chrome/common/extensions/api/_permission_features.json (right): https://chromiumcodereview.appspot.com/10690177/diff/16004/chrome/common/extensions/api/_permission_features.json#newcode46 chrome/common/extensions/api/_permission_features.json:46: "cloudPrintPrivate": { Nit: this should be moved down ...

8 years, 4 months ago (2012-07-31 21:15:30 UTC) #4

Vitaly Buka (NO REVIEWS)

https://chromiumcodereview.appspot.com/10690177/diff/16004/chrome/common/extensions/api/_permission_features.json File chrome/common/extensions/api/_permission_features.json (right): https://chromiumcodereview.appspot.com/10690177/diff/16004/chrome/common/extensions/api/_permission_features.json#newcode46 chrome/common/extensions/api/_permission_features.json:46: "cloudPrintPrivate": { On 2012/07/31 21:15:30, Mihai Parparita wrote: > ...

8 years, 4 months ago (2012-07-31 21:40:04 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10690177/17021

8 years, 4 months ago (2012-07-31 21:42:34 UTC) #6

commit-bot: I haz the power

Failed to apply patch for chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc: While running patch -p0 --forward --force; A chrome/browser/extensions/api/cloud_print_private patching ...

8 years, 4 months ago (2012-07-31 21:42:44 UTC) #7

Vitaly Buka (NO REVIEWS)

Hi Chris and Nico, please review as OWNERs of chrome and chrome\browser\resources

8 years, 4 months ago (2012-07-31 21:48:31 UTC) #8

lgtm

Expand Messages | Collapse Messages