Choose Virtual Me2Me X session based on installed components.

Choose Virtual Me2Me X session based on installed components.

This updates the Virtual Me2Me script to work on Ubuntu 12.04 as well as Ubuntu
10.04.


BUG=131440
TEST=manual


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147350

[Wez, 2012-07-12 21:18:14]

http://codereview.chromium.org/10690175/diff/1/remoting/tools/me2me_virtual_h...
File remoting/tools/me2me_virtual_host.py (right):

http://codereview.chromium.org/10690175/diff/1/remoting/tools/me2me_virtual_h...
remoting/tools/me2me_virtual_host.py:36: # The X session command is normally
determined automatically.  To use a
nit: "By default this script will try to determine the X session command
automatically."

http://codereview.chromium.org/10690175/diff/1/remoting/tools/me2me_virtual_h...
remoting/tools/me2me_virtual_host.py:449: """Finds an appropriate choice of X
session command for this system.
nit: "Chooses the most appropriate X session command for this system."

http://codereview.chromium.org/10690175/diff/1/remoting/tools/me2me_virtual_h...
remoting/tools/me2me_virtual_host.py:456: way, any problems or errors can be
reported before daemonization occurs.
You print the information to stderr so that it will be displayed to the user
when they actually run the script?  (The way the comment is worded it sounds
like stderr output is an unavoidable side-effect rather than a desired
behaviour!)

http://codereview.chromium.org/10690175/diff/1/remoting/tools/me2me_virtual_h...
remoting/tools/me2me_virtual_host.py:471: return candidate
You could structure this as a dictionary of {file-to-test-for:
command-line-to-run} pairs, so that you don't need to treat Unity-2D as a
special case.

http://codereview.chromium.org/10690175/diff/1/remoting/tools/me2me_virtual_h...
remoting/tools/me2me_virtual_host.py:482: "the gnome-session-fallback package,
and restart this script.\n")
It would be cleaner to have the calling code test the result of choose_x_session
and print a message to the user if Unity was chosen, I think, rather than have
it as a side-effect of this function.

e.g. if "unity-2d" in XSESSION_COMMAND: ...

[Lambros, 2012-07-13 00:30:18]

http://codereview.chromium.org/10690175/diff/1/remoting/tools/me2me_virtual_h...
File remoting/tools/me2me_virtual_host.py (right):

http://codereview.chromium.org/10690175/diff/1/remoting/tools/me2me_virtual_h...
remoting/tools/me2me_virtual_host.py:36: # The X session command is normally
determined automatically.  To use a
On 2012/07/12 21:18:14, Wez wrote:
> nit: "By default this script will try to determine the X session command
> automatically."

Done.

http://codereview.chromium.org/10690175/diff/1/remoting/tools/me2me_virtual_h...
remoting/tools/me2me_virtual_host.py:449: """Finds an appropriate choice of X
session command for this system.
On 2012/07/12 21:18:14, Wez wrote:
> nit: "Chooses the most appropriate X session command for this system."

Done.

http://codereview.chromium.org/10690175/diff/1/remoting/tools/me2me_virtual_h...
remoting/tools/me2me_virtual_host.py:456: way, any problems or errors can be
reported before daemonization occurs.
On 2012/07/12 21:18:14, Wez wrote:
> You print the information to stderr so that it will be displayed to the user
> when they actually run the script?  (The way the comment is worded it sounds
> like stderr output is an unavoidable side-effect rather than a desired
> behaviour!)
Removed the side-effect.

http://codereview.chromium.org/10690175/diff/1/remoting/tools/me2me_virtual_h...
remoting/tools/me2me_virtual_host.py:471: return candidate
On 2012/07/12 21:18:14, Wez wrote:
> You could structure this as a dictionary of {file-to-test-for:
> command-line-to-run} pairs, so that you don't need to treat Unity-2D as a
> special case.
Done, but with a list instead of a dictionary, because
the order is important :)

http://codereview.chromium.org/10690175/diff/1/remoting/tools/me2me_virtual_h...
remoting/tools/me2me_virtual_host.py:482: "the gnome-session-fallback package,
and restart this script.\n")
On 2012/07/12 21:18:14, Wez wrote:
> It would be cleaner to have the calling code test the result of
choose_x_session
> and print a message to the user if Unity was chosen, I think, rather than have
> it as a side-effect of this function.
> 
> e.g. if "unity-2d" in XSESSION_COMMAND: ...

Done.

[Wez, 2012-07-18 20:23:51]

lgtm

[commit-bot: I haz the power, 2012-07-18 23:01:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/10690175/3002

[commit-bot: I haz the power, 2012-07-19 00:09:05]

Change committed as 147350