Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 10690175: Choose Virtual Me2Me X session based on installed components. (Closed)

Created:
8 years, 5 months ago by Lambros
Modified:
8 years, 5 months ago
Reviewers:
Wez
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, pam+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Choose Virtual Me2Me X session based on installed components. This updates the Virtual Me2Me script to work on Ubuntu 12.04 as well as Ubuntu 10.04. BUG=131440 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147350

Patch Set 1 #

Total comments: 10

Patch Set 2 : Remove side-effect from choose_x_session() and fix nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -4 lines) Patch
M remoting/tools/me2me_virtual_host.py View 1 4 chunks +55 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lambros
8 years, 5 months ago (2012-07-12 21:03:38 UTC) #1
Wez
http://codereview.chromium.org/10690175/diff/1/remoting/tools/me2me_virtual_host.py File remoting/tools/me2me_virtual_host.py (right): http://codereview.chromium.org/10690175/diff/1/remoting/tools/me2me_virtual_host.py#newcode36 remoting/tools/me2me_virtual_host.py:36: # The X session command is normally determined automatically. ...
8 years, 5 months ago (2012-07-12 21:18:14 UTC) #2
Lambros
http://codereview.chromium.org/10690175/diff/1/remoting/tools/me2me_virtual_host.py File remoting/tools/me2me_virtual_host.py (right): http://codereview.chromium.org/10690175/diff/1/remoting/tools/me2me_virtual_host.py#newcode36 remoting/tools/me2me_virtual_host.py:36: # The X session command is normally determined automatically. ...
8 years, 5 months ago (2012-07-13 00:30:18 UTC) #3
Wez
lgtm
8 years, 5 months ago (2012-07-18 20:23:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/10690175/3002
8 years, 5 months ago (2012-07-18 23:01:50 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-19 00:09:05 UTC) #6
Change committed as 147350

Powered by Google App Engine
This is Rietveld 408576698