base/test/main_hook.h - Issue 10690161: Make it possible to run gtests on iOS.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/test/main_hook.h

Issue 10690161: Make it possible to run gtests on iOS. (Closed) Base URL: http://git.chromium.org/chromium/src.git@presubmit_change

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "build/build_config.h"

	6 #include "base/basictypes.h"

	7

	8 class MainHook {
	stuartmorgan 2012/07/12 09:36:31 Needs a class level comment (just explaining that Needs a class level comment (just explaining that it provides a way of running code intended to be run before starting gtest-based tests, or something like that). leng 2012/07/12 10:44:42 Done. Show quoted text On 2012/07/12 09:36:31, stuartmorgan wrote: > Needs a class level comment (just explaining that it provides a way of running > code intended to be run before starting gtest-based tests, or something like > that). Done.
	9 public:
	stuartmorgan 2012/07/12 09:36:31 Indent 1 Indent 1 leng 2012/07/12 10:44:42 Done. Show quoted text On 2012/07/12 09:36:31, stuartmorgan wrote: > Indent 1 Done.
	10 typedef int (MainType)(int, char[]);

	11 MainHook(MainType main_func, int argc, char* argv[])

	12 #if !defined(OS_IOS)
	stuartmorgan 2012/07/12 09:36:31 While it seems a bit silly, I think it would proba While it seems a bit silly, I think it would probably be better to make a main_hook.cc with an #if !defined(OS_IO) implementation and get rid of the ugly ifdef. leng 2012/07/12 10:44:42 Done. Show quoted text On 2012/07/12 09:36:31, stuartmorgan wrote: > While it seems a bit silly, I think it would probably be better to make a > main_hook.cc with an #if !defined(OS_IO) implementation and get rid of the ugly > ifdef. Done.
	13 {}

	14 #else

	15 ;

	16 #endif

	17 private:
	stuartmorgan 2012/07/12 09:36:31 Indent 1 Indent 1 leng 2012/07/12 10:44:42 Done. Show quoted text On 2012/07/12 09:36:31, stuartmorgan wrote: > Indent 1 Done.
	18 DISALLOW_COPY_AND_ASSIGN(MainHook);

	19 };

	20

OLD	NEW

« no previous file with comments | « base/base.gyp ('k') | base/test/main_hook_ios.mm » ('j') | base/test/main_hook_ios.mm » ('J')