add abi support for emulator.py

add abi support for emulator.py

Currently arm emulator will always be launched. Adding abi support
to launch corresponding emulator for "TARGET_PRODUCT"

BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146310

[Wei James(wistoch), 2012-07-12 02:06:13]

launch x86 emulator when "TARGET_PRODUCT" set as "x86", otherwise, launch arm
emulator.

[bulach, 2012-07-12 07:45:06]

lgtm, thanks!

I have one suggestion below though:

http://codereview.chromium.org/10690157/diff/1/build/android/emulator.py
File build/android/emulator.py (right):

http://codereview.chromium.org/10690157/diff/1/build/android/emulator.py#newc...
build/android/emulator.py:152: if abi and "x86" in abi:
nit: single quotes here and in 151..
however, I think 151-155 would be clearer as:

abi = 'armeabi'
if 'x86' in os.environ.get('TARGET_PRODUCT', ''):
  abi = 'x86'

[Wei James(wistoch), 2012-07-12 08:09:55]

http://codereview.chromium.org/10690157/diff/1/build/android/emulator.py
File build/android/emulator.py (right):

http://codereview.chromium.org/10690157/diff/1/build/android/emulator.py#newc...
build/android/emulator.py:152: if abi and "x86" in abi:
On 2012/07/12 07:45:06, bulach wrote:
> nit: single quotes here and in 151..
> however, I think 151-155 would be clearer as:
> 
> abi = 'armeabi'
> if 'x86' in os.environ.get('TARGET_PRODUCT', ''):
>   abi = 'x86'

fixed. and thanks for the suggestion. agree that it is clearer. 

thanks

[bulach, 2012-07-12 08:10:37]

lgtm, nice, thanks!

[Wei James(wistoch), 2012-07-12 08:11:57]

On 2012/07/12 08:10:37, bulach wrote:
> lgtm, nice, thanks!

thanks. :)

[commit-bot: I haz the power, 2012-07-12 08:12:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/james.wei@intel.com/10690157/4001

[commit-bot: I haz the power, 2012-07-12 10:52:46]

Change committed as 146310