Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: chrome/browser/chromeos/gdata/gdata_cache_metadata.h

Issue 10690154: gdata: Remove a werid behavior from GDataCacheMetadata::UpdateCache() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/gdata/gdata_cache_metadata.h
diff --git a/chrome/browser/chromeos/gdata/gdata_cache_metadata.h b/chrome/browser/chromeos/gdata/gdata_cache_metadata.h
index fbcbfc096a6eafbdbe905741701ba99ca88fcace..53ad383ce4a8b3dd0254d60d00866b5c4e46b20c 100644
--- a/chrome/browser/chromeos/gdata/gdata_cache_metadata.h
+++ b/chrome/browser/chromeos/gdata/gdata_cache_metadata.h
@@ -35,13 +35,13 @@ class GDataCacheMetadata {
const base::SequencedWorkerPool::SequenceToken& sequence_token);
virtual ~GDataCacheMetadata();
- // Updates cache map with entry corresponding to |resource_id|.
- // Creates new entry if it doesn't exist, otherwise update the entry.
- virtual void UpdateCache(const std::string& resource_id,
- const GDataCacheEntry& cache_entry) = 0;
+ // Adds a new cache entry corresponding to |resource_id| if it doesn't
+ // exist, otherwise update the existing entry.
+ virtual void AddOrUpdateCacheEntry(const std::string& resource_id,
+ const GDataCacheEntry& cache_entry) = 0;
// Removes entry corresponding to |resource_id| from cache map.
- virtual void RemoveFromCache(const std::string& resource_id) = 0;
+ virtual void RemoveCacheEntry(const std::string& resource_id) = 0;
// Returns the cache entry for file corresponding to |resource_id| and |md5|
// if entry exists in cache map. Otherwise, returns NULL.
@@ -83,10 +83,10 @@ class GDataCacheMetadataMap : public GDataCacheMetadata {
void Initialize(const std::vector<FilePath>& cache_paths);
// GDataCacheMetadata overrides:
- virtual void UpdateCache(
+ virtual void AddOrUpdateCacheEntry(
const std::string& resource_id,
const GDataCacheEntry& cache_entry) OVERRIDE;
- virtual void RemoveFromCache(const std::string& resource_id) OVERRIDE;
+ virtual void RemoveCacheEntry(const std::string& resource_id) OVERRIDE;
virtual scoped_ptr<GDataCacheEntry> GetCacheEntry(
const std::string& resource_id,
const std::string& md5) OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698