chrome/browser/ui/network_profile_bubble.cc - Issue 10690151: Move implementation of BrowserList onto an inner, instantiatable class, BrowserListImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/network_profile_bubble.cc

Issue 10690151: Move implementation of BrowserList onto an inner, instantiatable class, BrowserListImpl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser_list_observer.h ('K') | « chrome/browser/ui/host_desktop.h ('k') | chrome/browser/ui/startup/startup_browser_creator_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/network_profile_bubble.cc

===================================================================

--- chrome/browser/ui/network_profile_bubble.cc (revision 146126)

+++ chrome/browser/ui/network_profile_bubble.cc (working copy)

@@ -21,6 +21,7 @@

#include "chrome/browser/prefs/pref_service.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser_list.h"

+#include "chrome/browser/ui/browser_list_observer.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/common/pref_names.h"

#include "content/public/browser/browser_thread.h"

@@ -34,12 +35,13 @@

// silent period starts.

const int kMaxWarnings = 2;

-// Implementation of BrowserList::Observer used to wait for a browser window.

-class BrowserListObserver : public BrowserList::Observer {

+// Implementation of chrome::BrowserListObserver used to wait for a browser

+// window.

+class BrowserListObserver : public chrome::BrowserListObserver {

private:

virtual ~BrowserListObserver();

- // Overridden from BrowserList::Observer:

+ // Overridden from chrome::BrowserListObserver:

virtual void OnBrowserAdded(Browser* browser) OVERRIDE;

virtual void OnBrowserRemoved(Browser* browser) OVERRIDE;

virtual void OnBrowserSetLastActive(Browser* browser) OVERRIDE;