chrome/browser/protector/settings_change_global_error.h - Issue 10690151: Move implementation of BrowserList onto an inner, instantiatable class, BrowserListImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/protector/settings_change_global_error.h

Issue 10690151: Move implementation of BrowserList onto an inner, instantiatable class, BrowserListImpl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/profiles/profile_manager.cc ('k') | chrome/browser/protector/settings_change_global_error.cc » ('j') | chrome/browser/ui/browser_list_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/protector/settings_change_global_error.h

===================================================================

--- chrome/browser/protector/settings_change_global_error.h (revision 146126)

+++ chrome/browser/protector/settings_change_global_error.h (working copy)

@@ -11,7 +11,7 @@

#include "base/memory/weak_ptr.h"

#include "chrome/app/chrome_command_ids.h"

#include "chrome/browser/protector/base_setting_change.h"

-#include "chrome/browser/ui/browser_list.h"

+#include "chrome/browser/ui/browser_list_observer.h"

#include "chrome/browser/ui/global_error/global_error.h"

class Browser;

@@ -24,7 +24,7 @@

// Global error about unwanted settings changes.

class SettingsChangeGlobalError : public GlobalError,

- public BrowserList::Observer {

+ public chrome::BrowserListObserver {

public:

// Creates new global error about setting changes |change| which must not be

// deleted until |delegate->OnRemovedFromProfile| is called. Uses |delegate|

@@ -65,7 +65,7 @@

virtual void BubbleViewAcceptButtonPressed(Browser* browser) OVERRIDE;

virtual void BubbleViewCancelButtonPressed(Browser* browser) OVERRIDE;

- // BrowserList::Observer implementation.

+ // chrome::BrowserListObserver implementation.

virtual void OnBrowserAdded(Browser* browser) OVERRIDE {}

virtual void OnBrowserRemoved(Browser* browser) OVERRIDE {}

virtual void OnBrowserSetLastActive(Browser* browser) OVERRIDE;