chrome/browser/extensions/api/web_navigation/web_navigation_api.h - Issue 10690151: Move implementation of BrowserList onto an inner, instantiatable class, BrowserListImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_api.h

Issue 10690151: Move implementation of BrowserList onto an inner, instantiatable class, BrowserListImpl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/file_manager_util.cc ('k') | chrome/browser/extensions/api/web_navigation/web_navigation_api.cc » ('j') | chrome/browser/ui/browser_list_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_navigation/web_navigation_api.h

===================================================================

--- chrome/browser/extensions/api/web_navigation/web_navigation_api.h (revision 146126)

+++ chrome/browser/extensions/api/web_navigation/web_navigation_api.h (working copy)

@@ -15,7 +15,7 @@

#include "base/compiler_specific.h"

#include "chrome/browser/extensions/extension_function.h"

#include "chrome/browser/profiles/profile.h"

-#include "chrome/browser/ui/browser_list.h"

+#include "chrome/browser/ui/browser_list_observer.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

#include "content/public/browser/notification_observer.h"

#include "content/public/browser/notification_registrar.h"

@@ -196,7 +196,7 @@

// Observes navigation notifications and routes them as events to the extension

// system.

class WebNavigationEventRouter : public TabStripModelObserver,

- public BrowserList::Observer,

+ public chrome::BrowserListObserver,

public content::NotificationObserver {

public:

explicit WebNavigationEventRouter(Profile* profile);

@@ -230,7 +230,7 @@

TabContents* new_contents,

int index) OVERRIDE;

- // BrowserList::Observer implementation.

+ // chrome::BrowserListObserver implementation.

virtual void OnBrowserAdded(Browser* browser) OVERRIDE;

virtual void OnBrowserRemoved(Browser* browser) OVERRIDE;