gdata: Move GDataCache::CacheEntry out of GDataCache

gdata: Move GDataCache::CacheEntry out of GDataCache

Along the way, rename it to GDataCacheEntry to be consistent
with other classes, and put it in a separate header file.

FWIW, nested classes are usually avoided.
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Nested_Classes

BUG=136625
TEST=out/Release/unit_tests --gtest_filter=GData*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146236

[satorux1, 2012-07-11 23:02:40]

It's getting much saner...

[hshi1, 2012-07-11 23:17:36]

http://codereview.chromium.org/10690149/diff/7001/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_cache_entry.h (right):

http://codereview.chromium.org/10690149/diff/7001/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_cache_entry.h:20: };
Nit: This enum GDataCacheState is directly defined under namespace gdata,
whereas enum GDataCacheSubdirectoryType is defined under namespace
gdata::GDataCache. I understand that it is actually not necessary to define the
enum inside the class GDataCacheEntry but it seems not very consistent.

LGTM otherwise.

[satorux1, 2012-07-11 23:28:18]

http://codereview.chromium.org/10690149/diff/7001/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_cache_entry.h (right):

http://codereview.chromium.org/10690149/diff/7001/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_cache_entry.h:20: };
On 2012/07/11 23:17:36, hshi1 wrote:
> Nit: This enum GDataCacheState is directly defined under namespace gdata,
> whereas enum GDataCacheSubdirectoryType is defined under namespace
> gdata::GDataCache. I understand that it is actually not necessary to define
the
> enum inside the class GDataCacheEntry but it seems not very consistent.
> 
> LGTM otherwise.

You are right. We should move CacheSubdirectoryType out of the GDataCache class,
but let's do it in a separate patch. This patch is already pretty big.

[hshi1, 2012-07-11 23:33:09]

LGTM.