Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 10690146: Fix PepperFlashSettingsManager::Core initialization. (Closed)

Created:
8 years, 5 months ago by yzshen1
Modified:
8 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Fix PepperFlashSettingsManager::Core initialization. Previously, it is possible that before the newly created Core object is added ref by PepperFlashSettingsManager, Initialize() on the IO thread has caused the ref count to drop to 0 and destroy the object. This change makes sure that PepperFlashSettingsManager holds 1 ref before doing the initialization. BUG=132818 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146307

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -31 lines) Patch
M chrome/browser/pepper_flash_settings_manager.cc View 6 chunks +39 lines, -31 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
yzshen1
Hi, Brett. Could you please take a look? Thanks!
8 years, 5 months ago (2012-07-11 22:38:21 UTC) #1
brettw
Ah! Makes sense. LGTM
8 years, 5 months ago (2012-07-12 04:11:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/10690146/1
8 years, 5 months ago (2012-07-12 05:55:14 UTC) #3
commit-bot: I haz the power
Try job failure for 10690146-1 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 5 months ago (2012-07-12 06:57:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/10690146/1
8 years, 5 months ago (2012-07-12 08:12:35 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-12 09:25:55 UTC) #6
Change committed as 146307

Powered by Google App Engine
This is Rietveld 408576698