Move function serialization to sync ports.

client/dart.js

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // Bootstrap support for Dart scripts on the page as this script.
 if (navigator.webkitStartDart) {
   if (!navigator.webkitStartDart()) {
     document.body.innerHTML = 'This build has expired.  Please download a new Dartium at http://www.dartlang.org/dartium/index.html';
   }
 } else {
@@ skipping 71 matching lines @@
     if (x == null ||
         typeof(x) == 'string' ||
         typeof(x) == 'number' ||
         typeof(x) == 'boolean') {
       return x;
     }
     switch (x[0]) {
       case 'map': return deserializeMap(x);
       case 'sendport': return deserializeSendPort(x);
       case 'list': return deserializeList(x);
+      case 'funcref': return deserializeFunction(x);

[vsm, 2012/08/10 00:18:50]

How about a more descriptive name?  E.g., 'function-proxy'.

[Anton Muhin, 2012/08/14 16:42:38]

I can definitely do it, but I wished to minimize the length of the tag to reduce
size of data to pass.

But if you think we'd better start with more descriptive tags and optimize for
size later, I'll rename.

[vsm, 2012/08/15 15:35:38]

It's fine for now.

On 2012/08/14 16:42:38, Anton Muhin wrote:

       default: throw 'unimplemented';
     }
   }
 
   function deserializeMap(x) {
     var result = { };
     var id = x[1];
     var keys = x[2];
     var values = x[3];
     for (var i = 0, length = keys.length; i < length; i++) {
@@ skipping 22 matching lines @@
   function deserializeList(x) {
     var values = x[2];
     var length = values.length;
     var result = new Array(length);
     for (var i = 0; i < length; i++) {
       result[i] = deserializeHelper(values[i]);
     }
     return result;
   }
 
+  function deserializeFunction(x) {
+    var ref = x[1];
+    var sendPort = deserializeSendPort(x[2]);
+    // Number of arguments is not used as as of now

[vsm, 2012/08/10 00:18:50]

"as as" -> as

[Anton Muhin, 2012/08/14 16:42:38]

Done.

+    // we cannot find it out for Dart function in pure Dart.
+    return _makeFunctionFromRef(ref, sendPort);
+  }
+
   window.registerPort = function(name, port) {
     var stringified = JSON.stringify(serialize(port));
     window.localStorage['dart-port:' + name] = stringified;
   };
 
   window.lookupPort = function(name) {
     var stringified = window.localStorage['dart-port:' + name];
     return deserialize(JSON.parse(stringified));
   };
 
@@ skipping 63 matching lines @@
     var source = target + '-result';
     var result = null;
     var listener = function (e) {
       result = JSON.parse(e.data);
     };
     window.addEventListener(source, listener, false);
     dispatchEvent(target, [source, serialized]);
     window.removeEventListener(source, listener, false);
     return deserialize(result);
   }
+
+  // Leaking implementation.
+  // TODO: provide proper, backend-specific implementation.
+  function _makeFunctionFromRef(ref, sendPort) {
+    return function() {
+      return sendPort.callSync([ref, Array.prototype.slice.call(arguments)]);

[vsm, 2012/08/10 00:18:50]

Don't the arguments and return value need to be serialized and deserialized?

[Anton Muhin, 2012/08/14 16:42:38]

I don't remember all the details, but won't callSync take care of
serialization/deserialization?

On 2012/08/10 00:18:50, vsm wrote:

[vsm, 2012/08/15 15:35:38]

Yes, I think you're correct.

On 2012/08/14 16:42:38, Anton Muhin wrote:

+    }
+  }
 })();