Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Unified Diff: media/filters/ffmpeg_demuxer.cc

Issue 10690140: Reorganize bitstream converter classes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase again Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/ffmpeg_demuxer.h ('k') | media/filters/ffmpeg_h264_bitstream_converter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/ffmpeg_demuxer.cc
diff --git a/media/filters/ffmpeg_demuxer.cc b/media/filters/ffmpeg_demuxer.cc
index 00de84134f47c6e2b22b940d7dc55148b99b1fc0..2b66a04d205cd4eadbfcacfc6804e0f932309f22 100644
--- a/media/filters/ffmpeg_demuxer.cc
+++ b/media/filters/ffmpeg_demuxer.cc
@@ -21,9 +21,8 @@
#include "media/base/media_switches.h"
#include "media/base/video_decoder_config.h"
#include "media/ffmpeg/ffmpeg_common.h"
-#include "media/filters/bitstream_converter.h"
#include "media/filters/ffmpeg_glue.h"
-#include "media/filters/ffmpeg_h264_bitstream_converter.h"
+#include "media/filters/ffmpeg_h264_to_annex_b_bitstream_converter.h"
namespace media {
@@ -210,19 +209,9 @@ void FFmpegDemuxerStream::EnableBitstreamConverter() {
// Called by hardware decoder to require different bitstream converter.
// Currently we assume that converter is determined by codec_id;
DCHECK(stream_);
-
- if (stream_->codec->codec_id == CODEC_ID_H264) {
- // Use Chromium bitstream converter in case of H.264
- bitstream_converter_.reset(
- new FFmpegH264BitstreamConverter(stream_->codec));
- CHECK(bitstream_converter_->Initialize());
- } else if (stream_->codec->codec_id == CODEC_ID_MPEG4) {
- bitstream_converter_.reset(
- new FFmpegBitstreamConverter("mpeg4video_es", stream_->codec));
- CHECK(bitstream_converter_->Initialize());
- } else {
- NOTREACHED() << "Unsupported bitstream format.";
- }
+ DCHECK_EQ(stream_->codec->codec_id, CODEC_ID_H264);
+ bitstream_converter_.reset(
+ new FFmpegH264ToAnnexBBitstreamConverter(stream_->codec));
}
const AudioDecoderConfig& FFmpegDemuxerStream::audio_decoder_config() {
« no previous file with comments | « media/filters/ffmpeg_demuxer.h ('k') | media/filters/ffmpeg_h264_bitstream_converter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698