Don't create external extension providers for a TestExtensionSystem.

Don't create external extension providers for a TestExtensionSystem.

Otherwise, we might pick up external extensions during unit tests, which Breaks Stuff(tm).

BUG=136596
TEST=see bug for manual test


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146130

[Bernhard Bauer, 2012-07-11 15:39:25]

Please review.

[Yoyo Zhou, 2012-07-11 15:44:31]

LGTM, I've run into that problem before.

On Wed, Jul 11, 2012 at 8:39 AM,  <bauerb@chromium.org> wrote:
> Reviewers: Yoyo Zhou,
>
> Message:
> Please review.
>
> Description:
> Don't create external extension providers for a TestExtensionSystem.
>
> Otherwise, we might pick up external extensions during unit tests, which
> Breaks
> Stuff(tm).
>
> BUG=136596
> TEST=see bug for manual test
>
>
> Please review this at https://chromiumcodereview.appspot.com/10690139/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>   M chrome/browser/extensions/test_extension_system.cc
>
>
> Index: chrome/browser/extensions/test_extension_system.cc
> diff --git a/chrome/browser/extensions/test_extension_system.cc
> b/chrome/browser/extensions/test_extension_system.cc
> index
>
94093204ec75edd15738f66c8a9b0db694baa641..a129702985e3387cd066da0eeef3d88ad2f51657
> 100644
> --- a/chrome/browser/extensions/test_extension_system.cc
> +++ b/chrome/browser/extensions/test_extension_system.cc
> @@ -68,6 +68,7 @@ ExtensionService*
> TestExtensionSystem::CreateExtensionService(
>                                                  extension_prefs_.get(),
>                                                  autoupdate_enabled,
>                                                  true));
> +  extension_service_->ClearProvidersForTesting();
>    return extension_service_.get();
>  }
>
>
>

[commit-bot: I haz the power, 2012-07-11 15:46:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bauerb@chromium.org/10690139/1

[commit-bot: I haz the power, 2012-07-11 16:53:00]

Change committed as 146130