Get mac_logging and foundation_util working on iOS

base/mac/mac_logging.h

Index: base/mac/mac_logging.h
diff --git a/base/mac/mac_logging.h b/base/mac/mac_logging.h
index c463a35c9c8acef96f628f7d837f887405e2d8d2..112b1a9e3034ca33d0640c2a18fac2f637f4a45f 100644
--- a/base/mac/mac_logging.h
+++ b/base/mac/mac_logging.h
@@ -6,10 +6,15 @@
 #define BASE_MAC_MAC_LOGGING_H_
 #pragma once
 
-#include <libkern/OSTypes.h>
-
+#include "base/compiler_specific.h"

[Mark Mentovai, 2012/07/11 12:42:51]

You want:

#include "build/build_config.h"

for the OS_ macros. Not compiler_specific.h.

[stuartmorgan, 2012/07/11 13:18:42]

Done.

 #include "base/logging.h"

[Mark Mentovai, 2012/07/11 12:42:51]

Then you want to put this #include for base/logging.h back where you found it,
after the system includes. build_config.h gets to go up top because it’s needed
for the OS_* defines. logging.h still has to come after the system headers.

[stuartmorgan, 2012/07/11 13:18:42]

Hm, the reason I moved this is that the system headers are now
platform-specific, and our style says those go at the end:

#includes should be ordered per Google style, except platform-specific (#if
defined(..)) headers to follow the cross platform headers in a separate section
-- see the "Platform-specific code" section.

I thought that was true even for system headers, based on things I've seen in
other files. (See, e.g., base/time.h)

 
+#if defined(OS_IOS)
+#include "MacTypes.h"

[Mark Mentovai, 2012/07/11 12:42:51]

Very odd to see this in quotes. It should be <MacTypes.h>.

[stuartmorgan, 2012/07/11 13:18:42]

Done.

+#else
+#include <libkern/OSTypes.h>
+#endif
+
 // Use the OSSTATUS_LOG family to log messages related to errors in Mac OS X
 // system routines that report status via an OSStatus or OSErr value. It is
 // similar to the PLOG family which operates on errno, but because there is no