Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10690128: Reland r145993. (Closed)

Created:
8 years, 5 months ago by Nicolas Zea
Modified:
8 years, 5 months ago
Reviewers:
CC:
chromium-reviews, ncarter (slow), mihaip-chromium-reviews_chromium.org, akalin, Raghu Simha, Aaron Boodman, tim (not reviewing)
Visibility:
Public.

Description

Reland r145993. Original codereview at http://codereview.chromium.org/10766016/ [Sync] Add location parameter to SyncChange in Sync API. SyncChanges now require the location they were created as a parameter. This is then used in the case that the change violates and invariant. We display the location and type of erroneous change in about:sync, in addition to disabling the offending datatype. TBR=stevet@chromium.org, rlarocque@chromium.org BUG=135108 TEST=unit_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146050

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -93 lines) Patch
M chrome/browser/extensions/app_notification_manager.cc View 4 chunks +10 lines, -3 lines 0 comments Download
M chrome/browser/extensions/app_notification_manager_sync_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/app_sync_bundle.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/extensions/app_sync_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 12 chunks +36 lines, -20 lines 0 comments Download
M chrome/browser/extensions/extension_sync_bundle.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_sync_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/settings/settings_sync_util.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/prefs/pref_model_associator.cc View 3 chunks +9 lines, -3 lines 0 comments Download
M chrome/browser/search_engines/template_url_service.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service.cc View 18 chunks +51 lines, -25 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_sync_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/generic_change_processor.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/webdata/autocomplete_syncable_service.cc View 2 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/webdata/autofill_profile_syncable_service.cc View 3 chunks +14 lines, -9 lines 0 comments Download
M chrome/browser/webdata/autofill_profile_syncable_service_unittest.cc View 2 chunks +11 lines, -7 lines 0 comments Download
M sync/api/sync_change.h View 3 chunks +7 lines, -1 line 0 comments Download
M sync/api/sync_change.cc View 2 chunks +9 lines, -4 lines 0 comments Download
M sync/api/sync_change_unittest.cc View 6 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/10690128/1
8 years, 5 months ago (2012-07-11 02:38:47 UTC) #1
commit-bot: I haz the power
8 years, 5 months ago (2012-07-11 03:34:28 UTC) #2 
Change committed as 146050

Powered by Google App Engine
This is Rietveld 408576698