Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1626)

Unified Diff: chrome/browser/chromeos/gdata/gdata_cache.h

Issue 10690126: gdata: Use member functions of CacheEntry where it can (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address commentx Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/gdata/gdata_cache.h
diff --git a/chrome/browser/chromeos/gdata/gdata_cache.h b/chrome/browser/chromeos/gdata/gdata_cache.h
index de99af4fff7d7ef8fc28342c1d2c4da2dee1e1f6..e3280ae4c6ab74e2d626d1ccb82f66a2a77897ea 100644
--- a/chrome/browser/chromeos/gdata/gdata_cache.h
+++ b/chrome/browser/chromeos/gdata/gdata_cache.h
@@ -121,7 +121,7 @@ class GDataCache {
// Structure to store information of an existing cache file.
struct CacheEntry {
- CacheEntry() : cache_state(0) {}
+ CacheEntry() : cache_state(CACHE_STATE_NONE) {}
CacheEntry(const std::string& md5,
int cache_state)
@@ -149,7 +149,8 @@ class GDataCache {
// Callback for GetCacheEntryOnUIThread.
// |success| indicates if the operation was successful.
- // |cache_entry| is the obtained cache entry.
+ // |cache_entry| is the obtained cache entry. On failure, |cache_state| is
+ // set to CACHE_STATE_NONE.
//
// TODO(satorux): Unlike other callback types, this has to be defined
// inside GDataCache as CacheEntry is inside GDataCache. We should get them
« no previous file with comments | « chrome/browser/chromeos/extensions/file_browser_private_api.cc ('k') | chrome/browser/chromeos/gdata/gdata_cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698