Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: net/socket/ssl_client_socket_pool_unittest.cc

Issue 10690122: Change SpdySession::GetSSLInfo to get the SSLInfo from the underlying socket (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: FIx curvercp Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/socket/ssl_client_socket_openssl.cc ('k') | net/socket/ssl_client_socket_win.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/http/http_proxy_client_socket_pool.h" 5 #include "net/http/http_proxy_client_socket_pool.h"
6 6
7 #include "base/callback.h" 7 #include "base/callback.h"
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/string_util.h" 9 #include "base/string_util.h"
10 #include "base/time.h" 10 #include "base/time.h"
(...skipping 312 matching lines...) Expand 10 before | Expand all | Expand 10 after
323 int rv = handle.Init( 323 int rv = handle.Init(
324 "a", params, MEDIUM, callback.callback(), pool_.get(), BoundNetLog()); 324 "a", params, MEDIUM, callback.callback(), pool_.get(), BoundNetLog());
325 EXPECT_EQ(ERR_IO_PENDING, rv); 325 EXPECT_EQ(ERR_IO_PENDING, rv);
326 EXPECT_FALSE(handle.is_initialized()); 326 EXPECT_FALSE(handle.is_initialized());
327 EXPECT_FALSE(handle.socket()); 327 EXPECT_FALSE(handle.socket());
328 328
329 EXPECT_EQ(OK, callback.WaitForResult()); 329 EXPECT_EQ(OK, callback.WaitForResult());
330 EXPECT_TRUE(handle.is_initialized()); 330 EXPECT_TRUE(handle.is_initialized());
331 EXPECT_TRUE(handle.socket()); 331 EXPECT_TRUE(handle.socket());
332 SSLClientSocket* ssl_socket = static_cast<SSLClientSocket*>(handle.socket()); 332 SSLClientSocket* ssl_socket = static_cast<SSLClientSocket*>(handle.socket());
333 EXPECT_TRUE(ssl_socket->was_npn_negotiated()); 333 EXPECT_TRUE(ssl_socket->WasNpnNegotiated());
334 } 334 }
335 335
336 TEST_F(SSLClientSocketPoolTest, DirectNoSPDY) { 336 TEST_F(SSLClientSocketPoolTest, DirectNoSPDY) {
337 StaticSocketDataProvider data; 337 StaticSocketDataProvider data;
338 socket_factory_.AddSocketDataProvider(&data); 338 socket_factory_.AddSocketDataProvider(&data);
339 SSLSocketDataProvider ssl(ASYNC, OK); 339 SSLSocketDataProvider ssl(ASYNC, OK);
340 ssl.SetNextProto(kProtoHTTP11); 340 ssl.SetNextProto(kProtoHTTP11);
341 socket_factory_.AddSSLSocketDataProvider(&ssl); 341 socket_factory_.AddSSLSocketDataProvider(&ssl);
342 342
343 CreatePool(true /* tcp pool */, false, false); 343 CreatePool(true /* tcp pool */, false, false);
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
375 "a", params, MEDIUM, callback.callback(), pool_.get(), BoundNetLog()); 375 "a", params, MEDIUM, callback.callback(), pool_.get(), BoundNetLog());
376 EXPECT_EQ(ERR_IO_PENDING, rv); 376 EXPECT_EQ(ERR_IO_PENDING, rv);
377 EXPECT_FALSE(handle.is_initialized()); 377 EXPECT_FALSE(handle.is_initialized());
378 EXPECT_FALSE(handle.socket()); 378 EXPECT_FALSE(handle.socket());
379 379
380 EXPECT_EQ(OK, callback.WaitForResult()); 380 EXPECT_EQ(OK, callback.WaitForResult());
381 EXPECT_TRUE(handle.is_initialized()); 381 EXPECT_TRUE(handle.is_initialized());
382 EXPECT_TRUE(handle.socket()); 382 EXPECT_TRUE(handle.socket());
383 383
384 SSLClientSocket* ssl_socket = static_cast<SSLClientSocket*>(handle.socket()); 384 SSLClientSocket* ssl_socket = static_cast<SSLClientSocket*>(handle.socket());
385 EXPECT_TRUE(ssl_socket->was_npn_negotiated()); 385 EXPECT_TRUE(ssl_socket->WasNpnNegotiated());
386 std::string proto; 386 std::string proto;
387 std::string server_protos; 387 std::string server_protos;
388 ssl_socket->GetNextProto(&proto, &server_protos); 388 ssl_socket->GetNextProto(&proto, &server_protos);
389 EXPECT_EQ(SSLClientSocket::NextProtoFromString(proto), 389 EXPECT_EQ(SSLClientSocket::NextProtoFromString(proto),
390 kProtoSPDY2); 390 kProtoSPDY2);
391 } 391 }
392 392
393 TEST_F(SSLClientSocketPoolTest, DirectGotBonusSPDY) { 393 TEST_F(SSLClientSocketPoolTest, DirectGotBonusSPDY) {
394 StaticSocketDataProvider data; 394 StaticSocketDataProvider data;
395 socket_factory_.AddSocketDataProvider(&data); 395 socket_factory_.AddSocketDataProvider(&data);
(...skipping 11 matching lines...) Expand all
407 "a", params, MEDIUM, callback.callback(), pool_.get(), BoundNetLog()); 407 "a", params, MEDIUM, callback.callback(), pool_.get(), BoundNetLog());
408 EXPECT_EQ(ERR_IO_PENDING, rv); 408 EXPECT_EQ(ERR_IO_PENDING, rv);
409 EXPECT_FALSE(handle.is_initialized()); 409 EXPECT_FALSE(handle.is_initialized());
410 EXPECT_FALSE(handle.socket()); 410 EXPECT_FALSE(handle.socket());
411 411
412 EXPECT_EQ(OK, callback.WaitForResult()); 412 EXPECT_EQ(OK, callback.WaitForResult());
413 EXPECT_TRUE(handle.is_initialized()); 413 EXPECT_TRUE(handle.is_initialized());
414 EXPECT_TRUE(handle.socket()); 414 EXPECT_TRUE(handle.socket());
415 415
416 SSLClientSocket* ssl_socket = static_cast<SSLClientSocket*>(handle.socket()); 416 SSLClientSocket* ssl_socket = static_cast<SSLClientSocket*>(handle.socket());
417 EXPECT_TRUE(ssl_socket->was_npn_negotiated()); 417 EXPECT_TRUE(ssl_socket->WasNpnNegotiated());
418 std::string proto; 418 std::string proto;
419 std::string server_protos; 419 std::string server_protos;
420 ssl_socket->GetNextProto(&proto, &server_protos); 420 ssl_socket->GetNextProto(&proto, &server_protos);
421 EXPECT_EQ(SSLClientSocket::NextProtoFromString(proto), 421 EXPECT_EQ(SSLClientSocket::NextProtoFromString(proto),
422 kProtoSPDY2); 422 kProtoSPDY2);
423 } 423 }
424 424
425 TEST_F(SSLClientSocketPoolTest, SOCKSFail) { 425 TEST_F(SSLClientSocketPoolTest, SOCKSFail) {
426 StaticSocketDataProvider data; 426 StaticSocketDataProvider data;
427 data.set_connect_data(MockConnect(SYNCHRONOUS, ERR_CONNECTION_FAILED)); 427 data.set_connect_data(MockConnect(SYNCHRONOUS, ERR_CONNECTION_FAILED));
(...skipping 279 matching lines...) Expand 10 before | Expand all | Expand 10 after
707 "a", params, MEDIUM, callback.callback(), pool_.get(), BoundNetLog()); 707 "a", params, MEDIUM, callback.callback(), pool_.get(), BoundNetLog());
708 EXPECT_EQ(ERR_IO_PENDING, rv); 708 EXPECT_EQ(ERR_IO_PENDING, rv);
709 EXPECT_FALSE(handle->is_initialized()); 709 EXPECT_FALSE(handle->is_initialized());
710 EXPECT_FALSE(handle->socket()); 710 EXPECT_FALSE(handle->socket());
711 711
712 EXPECT_EQ(OK, callback.WaitForResult()); 712 EXPECT_EQ(OK, callback.WaitForResult());
713 EXPECT_TRUE(handle->is_initialized()); 713 EXPECT_TRUE(handle->is_initialized());
714 EXPECT_TRUE(handle->socket()); 714 EXPECT_TRUE(handle->socket());
715 715
716 SSLClientSocket* ssl_socket = static_cast<SSLClientSocket*>(handle->socket()); 716 SSLClientSocket* ssl_socket = static_cast<SSLClientSocket*>(handle->socket());
717 EXPECT_TRUE(ssl_socket->was_npn_negotiated()); 717 EXPECT_TRUE(ssl_socket->WasNpnNegotiated());
718 std::string proto; 718 std::string proto;
719 std::string server_protos; 719 std::string server_protos;
720 ssl_socket->GetNextProto(&proto, &server_protos); 720 ssl_socket->GetNextProto(&proto, &server_protos);
721 EXPECT_EQ(SSLClientSocket::NextProtoFromString(proto), 721 EXPECT_EQ(SSLClientSocket::NextProtoFromString(proto),
722 kProtoSPDY2); 722 kProtoSPDY2);
723 723
724 // TODO(rtenneti): MockClientSocket::GetPeerAddress returns 0 as the port 724 // TODO(rtenneti): MockClientSocket::GetPeerAddress returns 0 as the port
725 // number. Fix it to return port 80 and then use GetPeerAddress to AddAlias. 725 // number. Fix it to return port 80 and then use GetPeerAddress to AddAlias.
726 SpdySessionPoolPeer pool_peer(session_->spdy_session_pool()); 726 SpdySessionPoolPeer pool_peer(session_->spdy_session_pool());
727 pool_peer.AddAlias(test_hosts[0].addresses.front(), test_hosts[0].pair); 727 pool_peer.AddAlias(test_hosts[0].addresses.front(), test_hosts[0].pair);
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
786 "a", params, MEDIUM, callback.callback(), pool_.get(), BoundNetLog()); 786 "a", params, MEDIUM, callback.callback(), pool_.get(), BoundNetLog());
787 EXPECT_EQ(ERR_IO_PENDING, rv); 787 EXPECT_EQ(ERR_IO_PENDING, rv);
788 EXPECT_FALSE(handle->is_initialized()); 788 EXPECT_FALSE(handle->is_initialized());
789 EXPECT_FALSE(handle->socket()); 789 EXPECT_FALSE(handle->socket());
790 790
791 EXPECT_EQ(OK, callback.WaitForResult()); 791 EXPECT_EQ(OK, callback.WaitForResult());
792 EXPECT_TRUE(handle->is_initialized()); 792 EXPECT_TRUE(handle->is_initialized());
793 EXPECT_TRUE(handle->socket()); 793 EXPECT_TRUE(handle->socket());
794 794
795 SSLClientSocket* ssl_socket = static_cast<SSLClientSocket*>(handle->socket()); 795 SSLClientSocket* ssl_socket = static_cast<SSLClientSocket*>(handle->socket());
796 EXPECT_TRUE(ssl_socket->was_npn_negotiated()); 796 EXPECT_TRUE(ssl_socket->WasNpnNegotiated());
797 std::string proto; 797 std::string proto;
798 std::string server_protos; 798 std::string server_protos;
799 ssl_socket->GetNextProto(&proto, &server_protos); 799 ssl_socket->GetNextProto(&proto, &server_protos);
800 EXPECT_EQ(SSLClientSocket::NextProtoFromString(proto), 800 EXPECT_EQ(SSLClientSocket::NextProtoFromString(proto),
801 kProtoSPDY2); 801 kProtoSPDY2);
802 802
803 // TODO(rtenneti): MockClientSocket::GetPeerAddress returns 0 as the port 803 // TODO(rtenneti): MockClientSocket::GetPeerAddress returns 0 as the port
804 // number. Fix it to return port 80 and then use GetPeerAddress to AddAlias. 804 // number. Fix it to return port 80 and then use GetPeerAddress to AddAlias.
805 SpdySessionPoolPeer pool_peer(session_->spdy_session_pool()); 805 SpdySessionPoolPeer pool_peer(session_->spdy_session_pool());
806 pool_peer.AddAlias(test_hosts[0].addresses.front(), test_hosts[0].pair); 806 pool_peer.AddAlias(test_hosts[0].addresses.front(), test_hosts[0].pair);
(...skipping 27 matching lines...) Expand all
834 ssl.channel_id_sent = true; 834 ssl.channel_id_sent = true;
835 ssl.SetNextProto(kProtoSPDY2); 835 ssl.SetNextProto(kProtoSPDY2);
836 TestIPPoolingDisabled(&ssl); 836 TestIPPoolingDisabled(&ssl);
837 } 837 }
838 838
839 // It would be nice to also test the timeouts in SSLClientSocketPool. 839 // It would be nice to also test the timeouts in SSLClientSocketPool.
840 840
841 } // namespace 841 } // namespace
842 842
843 } // namespace net 843 } // namespace net
OLDNEW
« no previous file with comments | « net/socket/ssl_client_socket_openssl.cc ('k') | net/socket/ssl_client_socket_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698