Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Unified Diff: net/socket/socket_test_util.h

Issue 10690104: DeterministicSocketDataProvider should not be RefCounted (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: One more leak fix Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/deterministic_socket_data_unittest.cc ('k') | net/socket/socket_test_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/socket_test_util.h
diff --git a/net/socket/socket_test_util.h b/net/socket/socket_test_util.h
index 26a5075420374eba75299d47f409500edb61c176..2638afe936517faffd5d102150a2e78e136506b0 100644
--- a/net/socket/socket_test_util.h
+++ b/net/socket/socket_test_util.h
@@ -440,13 +440,13 @@ class DeterministicMockTCPClientSocket;
// For examples of how to use this class, see:
// deterministic_socket_data_unittests.cc
class DeterministicSocketData
- : public StaticSocketDataProvider,
- public base::RefCounted<DeterministicSocketData> {
+ : public StaticSocketDataProvider {
public:
// |reads| the list of MockRead completions.
// |writes| the list of MockWrite completions.
DeterministicSocketData(MockRead* reads, size_t reads_count,
MockWrite* writes, size_t writes_count);
+ virtual ~DeterministicSocketData();
// Consume all the data up to the give stop point (via SetStop()).
void Run();
@@ -481,12 +481,7 @@ class DeterministicSocketData
virtual void Reset() OVERRIDE;
virtual void CompleteRead() OVERRIDE {}
- protected:
- virtual ~DeterministicSocketData();
-
private:
- friend class base::RefCounted<DeterministicSocketData>;
-
// Invoke the read and write callbacks, if the timing is appropriate.
void InvokeCallbacks();
« no previous file with comments | « net/socket/deterministic_socket_data_unittest.cc ('k') | net/socket/socket_test_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698