Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 10690104: DeterministicSocketDataProvider should not be RefCounted (Closed)

Created:
8 years, 5 months ago by Ryan Sleevi
Modified:
8 years, 5 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

DeterministicSocketDataProvider should not be RefCounted BUG=123295 TEST=net_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145845

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix leak #

Patch Set 3 : One more leak fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -163 lines) Patch
M net/http/http_network_transaction_spdy2_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_network_transaction_spdy3_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_pipelined_connection_impl_unittest.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M net/http/http_pipelined_network_transaction_unittest.cc View 1 6 chunks +11 lines, -10 lines 0 comments Download
M net/http/http_proxy_client_socket_pool_spdy2_unittest.cc View 5 chunks +11 lines, -10 lines 0 comments Download
M net/http/http_proxy_client_socket_pool_spdy3_unittest.cc View 5 chunks +11 lines, -10 lines 0 comments Download
M net/http/http_stream_parser_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/socket/buffered_write_stream_socket_unittest.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M net/socket/deterministic_socket_data_unittest.cc View 1 3 chunks +6 lines, -2 lines 0 comments Download
M net/socket/socket_test_util.h View 2 chunks +2 lines, -7 lines 0 comments Download
M net/socket/socket_test_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_http_stream_spdy3_unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M net/spdy/spdy_network_transaction_spdy2_unittest.cc View 1 2 12 chunks +38 lines, -54 lines 0 comments Download
M net/spdy/spdy_network_transaction_spdy3_unittest.cc View 1 2 11 chunks +37 lines, -54 lines 0 comments Download
M net/spdy/spdy_proxy_client_socket_spdy2_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/spdy/spdy_proxy_client_socket_spdy3_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ryan Sleevi
Ryan: Almost all of these changes are in SPDY code and... since we talked about ...
8 years, 5 months ago (2012-07-09 04:04:26 UTC) #1
Ryan Hamilton
LGTM (assuming my comment does not actually point to a memory leak) Thanks for doing ...
8 years, 5 months ago (2012-07-09 17:35:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10690104/6017
8 years, 5 months ago (2012-07-10 04:34:01 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-10 06:24:52 UTC) #4
Change committed as 145845

Powered by Google App Engine
This is Rietveld 408576698