Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: runtime/vm/debugger.cc

Issue 10690053: Make sure breakpoints are enabled (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger.cc
===================================================================
--- runtime/vm/debugger.cc (revision 9258)
+++ runtime/vm/debugger.cc (working copy)
@@ -719,7 +719,9 @@
for (int i = 0; i < desc.Length(); i++) {
CodeBreakpoint* bpt = GetCodeBreakpoint(desc.PC(i));
if (bpt != NULL) {
- // There is already a breakpoint for this address. Leave it alone.
+ // There is already a breakpoint for this address. Make sure
+ // it is enabled.
+ bpt->Enable();
continue;
}
PcDescriptors::Kind kind = desc.DescriptorKind(i);
@@ -869,9 +871,11 @@
CodeBreakpoint* bpt = GetCodeBreakpoint(desc.PC(best_fit_index));
// We should only ever have one code breakpoint at the same address.
// If we find an existing breakpoint, it must be an internal one which
- // is used for stepping.
+ // is used for stepping, or one that was left over from previously
+ // deleting a source breakpoint. Make sure it's enabled.
if (bpt != NULL) {
ASSERT(bpt->src_bpt() == NULL);
+ bpt->Enable();
return bpt;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698