GTK: Changes to Extension Commands now take effect immediately.

GTK: Changes to Extension Commands now take effect immediately.

BUG=121420
TEST=Make a change to the browser action command on Chrome on GTK. Make sure it takes effect immediately.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148322

[Finnur, 2012-06-29 14:35:38]

Evan, can you give OWNERS LG?

Yoz, this is what I purposefully left out of my last changelist:

http://codereview.chromium.org/10701005/

http://codereview.chromium.org/10690042/diff/1/chrome/browser/ui/gtk/browser_...
File chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc (right):

http://codereview.chromium.org/10690042/diff/1/chrome/browser/ui/gtk/browser_...
chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc:462:
content::Source<GtkWindow>(window));
If we don't remove this, then double registration will occur on line 438 when we
change the shortcut in the config UI.

[Yoyo Zhou, 2012-06-29 18:30:58]

LGTM

https://chromiumcodereview.appspot.com/10690042/diff/1/chrome/browser/ui/gtk/...
File chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc (right):

https://chromiumcodereview.appspot.com/10690042/diff/1/chrome/browser/ui/gtk/...
chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc:212: if (extension_->id()
== payload->first &&
nit: looks funny to have these comparisons be differently ordered, right next to
each other

https://chromiumcodereview.appspot.com/10690042/diff/1/chrome/browser/ui/gtk/...
chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc:462:
content::Source<GtkWindow>(window));
On 2012/06/29 14:35:38, Finnur wrote:
> If we don't remove this, then double registration will occur on line 438 when
we
> change the shortcut in the config UI.

Yup.

[Evan Stade, 2012-07-02 18:31:53]

lgtm