Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Issue 10690037: Add iOS handling to filename_rules.gypi (Closed)

Created:
8 years, 5 months ago by stuartmorgan
Modified:
8 years, 5 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add iOS handling to filename_rules.gypi Includes .mm on iOS as well as Mac, and adds handling of an _ios suffix for iOS-only files. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144909

Patch Set 1 #

Total comments: 4

Patch Set 2 : Tweak regexes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M build/filename_rules.gypi View 1 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
stuartmorgan
8 years, 5 months ago (2012-06-29 10:14:17 UTC) #1
Mark Mentovai
https://chromiumcodereview.appspot.com/10690037/diff/1/build/filename_rules.gypi File build/filename_rules.gypi (right): https://chromiumcodereview.appspot.com/10690037/diff/1/build/filename_rules.gypi#newcode17 build/filename_rules.gypi:17: 'sources/': [ ['exclude', '_(cocoa|mac)(_unittest)?\\.(cc|m|mm)$'], Don’t lose the h here ...
8 years, 5 months ago (2012-06-29 13:17:28 UTC) #2
stuartmorgan
https://chromiumcodereview.appspot.com/10690037/diff/1/build/filename_rules.gypi File build/filename_rules.gypi (right): https://chromiumcodereview.appspot.com/10690037/diff/1/build/filename_rules.gypi#newcode17 build/filename_rules.gypi:17: 'sources/': [ ['exclude', '_(cocoa|mac)(_unittest)?\\.(cc|m|mm)$'], On 2012/06/29 13:17:28, Mark Mentovai ...
8 years, 5 months ago (2012-06-29 13:26:21 UTC) #3
Mark Mentovai
LGTM
8 years, 5 months ago (2012-06-29 13:35:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/10690037/5001
8 years, 5 months ago (2012-06-29 14:14:06 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-06-29 15:26:47 UTC) #6
Change committed as 144909

Powered by Google App Engine
This is Rietveld 408576698