Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 10690036: Fix compile errors on gcc 4.6. (Closed)

Created:
8 years, 5 months ago by Hironori Bono
Modified:
8 years, 5 months ago
Reviewers:
tony, Steve McKay, jamesr
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Fix compile errors on gcc 4.6. This changes prevents calling constructors webkit_glue::WebIntentServiceData::WebIntentServiceData() directly since it is prohibited by gcc 4.6 (-fpermissive). BUG=none TEST=build on gcc 4.6. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145118

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webkit/glue/web_intent_service_data_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Hironori Bono
8 years, 5 months ago (2012-06-29 06:21:00 UTC) #1
tony
LGTM. Is -fpermissive on by default in precise?
8 years, 5 months ago (2012-06-29 16:42:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hbono@chromium.org/10690036/1
8 years, 5 months ago (2012-07-02 01:09:20 UTC) #3
Hironori Bono
Greetings Tony, Even though I'm not an expert of Ubuntu, my Precise seems to use ...
8 years, 5 months ago (2012-07-02 01:11:23 UTC) #4
commit-bot: I haz the power
8 years, 5 months ago (2012-07-02 02:17:58 UTC) #5
The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is linux_rel, revision is 145115, job name
was 10690036-1 (retry) (retry) (retry) (retry).

Powered by Google App Engine
This is Rietveld 408576698