Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Unified Diff: utils/pub/repo_source.dart

Issue 10690032: Make VersionSolver source- and description-aware. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « utils/pub/pubspec.dart ('k') | utils/pub/root_source.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/pub/repo_source.dart
diff --git a/utils/pub/repo_source.dart b/utils/pub/repo_source.dart
index f12cfbcb2d009c30587d5542d167fde53f7396ff..86812e54f282d8ec311dec7feaa5c10b06bd9556 100644
--- a/utils/pub/repo_source.dart
+++ b/utils/pub/repo_source.dart
@@ -60,7 +60,10 @@ class RepoSource extends Source {
return join(parent, urlDir, "${parsed.first}-${id.version}");
}
- String packageName(PackageId id) => _parseDescription(id.description).first;
+ String packageName(description) => _parseDescription(description).first;
+
+ bool descriptionsEqual(description1, description2) =>
+ _parseDescription(description1) == _parseDescription(description2);
/**
* Ensures that [description] is a valid repo description.
« no previous file with comments | « utils/pub/pubspec.dart ('k') | utils/pub/root_source.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698