utils/pub/git_source.dart - Issue 10690032: Make VersionSolver source- and description-aware.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: utils/pub/git_source.dart

Issue 10690032: Make VersionSolver source- and description-aware. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Code review changes Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: utils/pub/git_source.dart

diff --git a/utils/pub/git_source.dart b/utils/pub/git_source.dart

index cada5abca41e33c657da335402c35b8628706d36..ae7f53b1a2489d61a1cf4f9c7fefc5ba08121597 100644

--- a/utils/pub/git_source.dart

+++ b/utils/pub/git_source.dart

@@ -47,8 +47,8 @@ class GitSource extends Source {

* The package name of a Git repo is the name of the directory into which

* it'll be cloned.

- String packageName(PackageId id) =>

- basename(id.description).replaceFirst(const RegExp("\.git\$"), "");

+ String packageName(description) =>

+ basename(description).replaceFirst(const RegExp("\.git\$"), "");

/**

* Ensures [description] is a Git URL.

« no previous file with comments | « utils/pub/entrypoint.dart ('k') | utils/pub/package.dart » ('j') | no next file with comments »