Issue 10690028: gdata: Get rid of GDataFileSystem::GetCacheState()

Issue 10690028: gdata: Get rid of GDataFileSystem::GetCacheState() (Closed)

Created:
8 years, 5 months ago by satorux1

Modified:
8 years, 5 months ago

Reviewers:
hshi1

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, achuith+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

gdata: Get rid of GDataFileSystem::GetCacheState() Instead, add GDataCache::GetCacheEntryOnUIThread(). BUG=133552 TEST=the existing testis covered this functionality Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144878

Patch Set 1 #

Total comments: 4

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+127 lines, -162 lines)			Patch
M	chrome/browser/chromeos/extensions/file_browser_private_api.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_browser_private_api.cc	View	2 chunks	+17 lines, -14 lines	2 comments	Download
M	chrome/browser/chromeos/gdata/gdata_cache.h	View	4 chunks	+28 lines, -3 lines	2 comments	Download
M	chrome/browser/chromeos/gdata/gdata_cache.cc	View	4 chunks	+50 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system.h	View	5 chunks	+2 lines, -22 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system.cc	View	5 chunks	+10 lines, -105 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc	View	5 chunks	+17 lines, -12 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/mock_gdata_file_system.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

hshi1

https://chromiumcodereview.appspot.com/10690028/diff/1/chrome/browser/chromeos/extensions/file_browser_private_api.cc File chrome/browser/chromeos/extensions/file_browser_private_api.cc (right): https://chromiumcodereview.appspot.com/10690028/diff/1/chrome/browser/chromeos/extensions/file_browser_private_api.cc#newcode1839 chrome/browser/chromeos/extensions/file_browser_private_api.cc:1839: if (success) { Should any action be taken when ...

8 years, 5 months ago (2012-06-28 22:11:21 UTC) #2

satorux1

http://codereview.chromium.org/10690028/diff/1/chrome/browser/chromeos/extensions/file_browser_private_api.cc File chrome/browser/chromeos/extensions/file_browser_private_api.cc (right): http://codereview.chromium.org/10690028/diff/1/chrome/browser/chromeos/extensions/file_browser_private_api.cc#newcode1839 chrome/browser/chromeos/extensions/file_browser_private_api.cc:1839: if (success) { On 2012/06/28 22:11:21, hshi1 wrote: > ...

8 years, 5 months ago (2012-06-28 22:41:17 UTC) #3

lgtm

Expand Messages | Collapse Messages